Fix Duplicates in Fuzzy Search #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The duplicate 'p' in the branch name was a typo, though I wish it was an intentional pun. |
|
Thanks for the fix @Calvinp , LGTM |
ssalinas
added a commit
that referenced
this pull request
Mar 8, 2016
Fix Duplicates in Fuzzy Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuzzy Search gave duplicates in certain situations. This is because there are two searches done, one based on task id and one based on host. Fuzzy returns an object containing the string it searched on. If both the task id and host match the filter, two non-equal fuzzy objects representing the same task are returned, and _.union doesn't see them as the same thing.
This fixes that problem by calling _.uniq after extracting the original object.