New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't capture ctrl-t #943

Merged
merged 1 commit into from Mar 17, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Mar 11, 2016

Capturing ctrl-t prevents someone on a Linux or Windows machine from using the common keyboard shortcut to open a new tab.

ctrl-t, which on a non-Mac system should open a new tab, now doesn't …
…get captured causing global search to open
@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Mar 17, 2016

Member

LGTM

Member

ssalinas commented Mar 17, 2016

LGTM

ssalinas added a commit that referenced this pull request Mar 17, 2016

@ssalinas ssalinas merged commit 9960b29 into master Mar 17, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the ctrl_t_no_search branch Mar 17, 2016

@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment