More Descriptive Error Message On Http 200 But No JSON #944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Instructs the user that a possible cause is an expired session, and to please log in again
| Messenger().error | ||
| message: ''' | ||
| <p>Expected JSON but received something else (possibly html). The response has been saved to your js console.</p> | ||
| <p>One possible cause is an http redirect to an html web page.</p> |
There was a problem hiding this comment.
I still think we can be a bit smarter about the messaging here. We can know if it is html by checking if the string starts with <!DOCTYPE html>. Then we can either say '...but received html' or '...but received something else' if we don't know.
Also, The one possible cause is very specific to our own use case. If there is no way for us to know that that might be the error, we shouldn't be mentioning possible causes.
…her than dumping the html on the screen as the error message
|
LGTM |
ssalinas
added a commit
that referenced
this pull request
Mar 17, 2016
…00-no-json More Descriptive Error Message On Http 200 But No JSON
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user's session expires, we send an http 302 redirect to the login page. However, the browser catches this and follows it without passing it off to the application. Then the application receives html when it was expecting JSON. This handles that problem by advising the user of the situation and that one possible cause is an expired session.