Opt out of even number across racks. - #949
Conversation
Adds a parameter to SingularityRequest to opt out of suggesting even numbers across racks, and the UI listens to this. Also when creating or updating requests through the UI, there is a checkbox to toggle this
|
Possible improvements in future iterations:
|
|
I think the last of those nice to haves (checkbox to ignore in the future) we should implement in this PR. Should just have to get the current request json, add the field, and POST it |
|
|
||
| requestObject.rackAffinity = @getSelect2Val "#rackAffinity-#{ type }" | ||
|
|
||
| debugger |
There was a problem hiding this comment.
You are right, editing that out.
|
Maybe just a simpler 'Don't show this prompt again for {requestId}' in terms of messaging |
|
Hmm I feel like it's important to specify that this applies to all users, not just the person who's clicking the button. |
|
That's fair, can add a 'for any user' to the end of the messaging, should also see if we can separate it just a bit more so it doesn't look like part of the radio buttons, the difference between the circle/square is pretty slight. |
|
👍 |
…veryone for this request forever, and made the checkbox for this in the edit form field remember current state
|
This is now implemented. Sending this request, plus the scale request, plus the bounce request (when scaling with bounce), and ensuring none of them conflicted caused a bit of trouble, but this is resolved now. |
|
Thanks for this @Calvinp , going to merge it into the the other PR branch since they go together |
Opt out of even number across racks.



Adds a parameter to SingularityRequest to opt out of suggesting even numbers across racks, and the UI listens to this.
Also when creating or updating requests through the UI, there is a checkbox to toggle this.