You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@wsorenson@tpetr traced back through the different PendingTypes we could possibly get in combination with the ONEOFF type. Those are: RETRY, DECOMISSIONED_SLAVE_OR_RACK, UPDATED_REQUEST, or TASK_DONE. No others are currently created for an on demand request.
RETRY -> create another identical oneoff, there is no conflict here as both kinds just schedule a single task with the relevant options DECOMISSIONED_SLAVE_OR_RACK - > no problem there, no new tasks will be scheduled for a oneoff TASK_DONE -> Similar, we do not schedule new tasks for a oneoff on task done UPDATED_REQUEST -> This was the only possible relevant one (for values like killOldNonLongRunningTasksAfterMillis which I don't believe we wired up for on demand anyway). However, when we encounter this pending type the update to request data is already finished and we do not schedule any new oneoff tasks for a UPDATED_REQUEST pending type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @jhaber @jonathanwgoodwin