New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent terminology and more ovbious deploy failure on task page #966

Merged
merged 11 commits into from Apr 5, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Mar 21, 2016

This includes several UI improvements around task and deploy failures:

On the task page:

  • Healthcheck failed notification now states that the task was killed, rather than task failed
  • If the healthcheck failed because a connection was refused, the healthcheck failed notification will state that it was probably a problem with the app, not the cluster
  • The healthcheck notification will not display if the deploy failed and killed the task after one healthcheck ran and failed (but not enough to kill the task)
  • If this task caused the deploy to fail, it will have a danger notification saying this (and linking to other causes)
  • If this task's deploy failed, but this task was not a cause of that failure, then it will have a warn notification. This notification will state if the task was killed because the deploy failed, and it will link to failure causes.

On the deploy page:

  • Rather than say (n) tasks failed, now the message states how many causes of deploy failure there were. Those two numbers don't always match and caused some confusion.
  • The links to the tasks that failed will now have the taskIds bolded to make it more clear that they are links to the task pages.

Calvinp added some commits Mar 18, 2016

Healthcheck failure message won't show if task killed because deploy …
…failed; Healthcheck failure message will mention user app if connection refused; Healthcheck failure message will say 'task killed' instead of 'task failed'
@@ -0,0 +1,44 @@
{{#ifEqual deploy.deployResult.deployState "FAILED"}}

This comment has been minimized.

@ssalinas

ssalinas Mar 22, 2016

Member

if our task 404s you are not fetching the deploy info and are instead setting it to '', this if statement will throw 'has no attribute deployResult ...' type errors. Probably want to check that deploy is defined first

@ssalinas

ssalinas Mar 22, 2016

Member

if our task 404s you are not fetching the deploy info and are instead setting it to '', this if statement will throw 'has no attribute deployResult ...' type errors. Probably want to check that deploy is defined first

This comment has been minimized.

@Calvinp

Calvinp Mar 23, 2016

Contributor

Fixed

@Calvinp

Calvinp Mar 23, 2016

Contributor

Fixed

@Calvinp Calvinp added the hs_staging label Mar 23, 2016

@Calvinp Calvinp added the hs_qa label Mar 24, 2016

@Calvinp

This comment has been minimized.

Show comment
Hide comment
@Calvinp

Calvinp Mar 24, 2016

Contributor

A task's failed healthchecks caused its deploy to fail. There weren't enough failed healthchecks to fail the task, but there were enough to fail the deploy. This then caused the task to be killed.

It is probably appropriate to show the healthcheck notification in this edge case. It is not being shown right now because this PR doesn't show the notification when the failing deploy caused the task to fail. Maybe if this task is one of the deploy failure causes, show the healthcheck notification anyway. That might cause other edge case failures (task triggers a deploy failure for some reason other than failing healthchecks -> deploy fails -> task killed), but I'm not sure how to detect and account for all possibilities.

Contributor

Calvinp commented Mar 24, 2016

A task's failed healthchecks caused its deploy to fail. There weren't enough failed healthchecks to fail the task, but there were enough to fail the deploy. This then caused the task to be killed.

It is probably appropriate to show the healthcheck notification in this edge case. It is not being shown right now because this PR doesn't show the notification when the failing deploy caused the task to fail. Maybe if this task is one of the deploy failure causes, show the healthcheck notification anyway. That might cause other edge case failures (task triggers a deploy failure for some reason other than failing healthchecks -> deploy fails -> task killed), but I'm not sure how to detect and account for all possibilities.

@Calvinp Calvinp added the hs_stable label Mar 25, 2016

@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 5, 2016

Member

This has been looking good, messaging is much more clear, thanks @Calvinp

Member

ssalinas commented Apr 5, 2016

This has been looking good, messaging is much more clear, thanks @Calvinp

@ssalinas ssalinas merged commit 4ec150d into master Apr 5, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssalinas ssalinas deleted the consistent-terminology-more-ovbious-deploy-failure-on-task-page branch Apr 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment