Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Consistent terminology and more ovbious deploy failure on task page #966
This includes several UI improvements around task and deploy failures:
On the task page:
On the deploy page:
…failed; Healthcheck failure message will mention user app if connection refused; Healthcheck failure message will say 'task killed' instead of 'task failed'
… task that failed the deploy
…rather than repeating code needlessly
…when deploy can't be loaded
A task's failed healthchecks caused its deploy to fail. There weren't enough failed healthchecks to fail the task, but there were enough to fail the deploy. This then caused the task to be killed.
It is probably appropriate to show the healthcheck notification in this edge case. It is not being shown right now because this PR doesn't show the notification when the failing deploy caused the task to fail. Maybe if this task is one of the deploy failure causes, show the healthcheck notification anyway. That might cause other edge case failures (task triggers a deploy failure for some reason other than failing healthchecks -> deploy fails -> task killed), but I'm not sure how to detect and account for all possibilities.