Skip to content

Consistent terminology and more ovbious deploy failure on task page#966

Merged
ssalinas merged 11 commits intomasterfrom
consistent-terminology-more-ovbious-deploy-failure-on-task-page
Apr 5, 2016
Merged

Consistent terminology and more ovbious deploy failure on task page#966
ssalinas merged 11 commits intomasterfrom
consistent-terminology-more-ovbious-deploy-failure-on-task-page

Conversation

@Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Mar 21, 2016

This includes several UI improvements around task and deploy failures:

On the task page:

  • Healthcheck failed notification now states that the task was killed, rather than task failed
  • If the healthcheck failed because a connection was refused, the healthcheck failed notification will state that it was probably a problem with the app, not the cluster
  • The healthcheck notification will not display if the deploy failed and killed the task after one healthcheck ran and failed (but not enough to kill the task)
  • If this task caused the deploy to fail, it will have a danger notification saying this (and linking to other causes)
  • If this task's deploy failed, but this task was not a cause of that failure, then it will have a warn notification. This notification will state if the task was killed because the deploy failed, and it will link to failure causes.

On the deploy page:

  • Rather than say (n) tasks failed, now the message states how many causes of deploy failure there were. Those two numbers don't always match and caused some confusion.
  • The links to the tasks that failed will now have the taskIds bolded to make it more clear that they are links to the task pages.

Calvin Pomerantz added 5 commits March 18, 2016 16:17
…failed; Healthcheck failure message will mention user app if connection refused; Healthcheck failure message will say 'task killed' instead of 'task failed'
@listenTo @model, 'sync', @render
@listenTo @pendingDeploys, 'sync', @render

deployFailureKilledTask: =>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like this method is used. You can probably eliminate the section below where it is calculated in renderData and just use this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was getting errors using the function at first, but it seems to be working now so I'll use the function.

@Calvinp Calvinp added the hs_qa label Mar 24, 2016
@Calvinp
Copy link
Contributor Author

Calvinp commented Mar 24, 2016

A task's failed healthchecks caused its deploy to fail. There weren't enough failed healthchecks to fail the task, but there were enough to fail the deploy. This then caused the task to be killed.

It is probably appropriate to show the healthcheck notification in this edge case. It is not being shown right now because this PR doesn't show the notification when the failing deploy caused the task to fail. Maybe if this task is one of the deploy failure causes, show the healthcheck notification anyway. That might cause other edge case failures (task triggers a deploy failure for some reason other than failing healthchecks -> deploy fails -> task killed), but I'm not sure how to detect and account for all possibilities.

@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016
@ssalinas
Copy link
Member

ssalinas commented Apr 5, 2016

This has been looking good, messaging is much more clear, thanks @Calvinp

@ssalinas ssalinas merged commit 4ec150d into master Apr 5, 2016
@ssalinas ssalinas deleted the consistent-terminology-more-ovbious-deploy-failure-on-task-page branch April 5, 2016 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants