Better Slave Decommissioned / Offline Communication - #968
Merged
Conversation
Calvinp
commented
Mar 23, 2016
Contributor
- The alert for a slave decommissioning is now at warn level, not danger level
- The wording of the alert now suggests that this is a normal Singularity action, nothing is on fire, your task has been replaced, and you can continue about your day without (much) worry
- If a slave is offline, the scary ajax error stating so is now caught if it appears when trying to fetch files
- Instead of the scary ajax error, the files table now says that the slave is offline so we don't have files.
… task fles table states if the slave is offline, and there isn't a scary ajax error if the slave is offline
Contributor
|
Thanks for this @Calvinp , messaging is much clearer (and less alarming!) now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.