Skip to content

Better Slave Decommissioned / Offline Communication - #968

Merged
ssalinas merged 1 commit into
masterfrom
slave-decomissioning-alert
Mar 29, 2016
Merged

Better Slave Decommissioned / Offline Communication#968
ssalinas merged 1 commit into
masterfrom
slave-decomissioning-alert

Conversation

@Calvinp

@Calvinp Calvinp commented Mar 23, 2016

Copy link
Copy Markdown
Contributor
  • The alert for a slave decommissioning is now at warn level, not danger level
  • The wording of the alert now suggests that this is a normal Singularity action, nothing is on fire, your task has been replaced, and you can continue about your day without (much) worry
  • If a slave is offline, the scary ajax error stating so is now caught if it appears when trying to fetch files
  • Instead of the scary ajax error, the files table now says that the slave is offline so we don't have files.

… task fles table states if the slave is offline, and there isn't a scary ajax error if the slave is offline
@ssalinas

Copy link
Copy Markdown
Contributor

Thanks for this @Calvinp , messaging is much clearer (and less alarming!) now

@ssalinas
ssalinas merged commit ba1c91d into master Mar 29, 2016
@ssalinas
ssalinas deleted the slave-decomissioning-alert branch March 29, 2016 12:49
@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants