New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Slave Decommissioned / Offline Communication #968

Merged
merged 1 commit into from Mar 29, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Mar 23, 2016

  • The alert for a slave decommissioning is now at warn level, not danger level
  • The wording of the alert now suggests that this is a normal Singularity action, nothing is on fire, your task has been replaced, and you can continue about your day without (much) worry
  • If a slave is offline, the scary ajax error stating so is now caught if it appears when trying to fetch files
  • Instead of the scary ajax error, the files table now says that the slave is offline so we don't have files.
Alert for slave decomm causing task failure is now a warn not danger,…
… task fles table states if the slave is offline, and there isn't a scary ajax error if the slave is offline
@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Mar 29, 2016

Member

Thanks for this @Calvinp , messaging is much clearer (and less alarming!) now

Member

ssalinas commented Mar 29, 2016

Thanks for this @Calvinp , messaging is much clearer (and less alarming!) now

@ssalinas ssalinas merged commit ba1c91d into master Mar 29, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the slave-decomissioning-alert branch Mar 29, 2016

@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment