Task badge color for TASK_KILLED is now default (grey)#970
Merged
Conversation
Member
|
Much easier to distinguish failed/lost from the killed tasks now. And +1 for consolidating the colors all to one place for these |
Contributor
Author
|
Thanks for the +1, though I'm not sure how well deserved it is on my part since I'm the one who split the colors in the first place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The color for TASK_KILLED badges is now grey, the bootstrap default color, to distinguish it from TASK_FAILED.
The two getLabelClass functions were combined into one helper function in utils to avert confusion when changing these colors in the future.