Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task badge color for TASK_KILLED is now default (grey) #970

Merged
merged 1 commit into from Mar 29, 2016

Conversation

@Calvinp
Copy link
Contributor

Calvinp commented Mar 24, 2016

The color for TASK_KILLED badges is now grey, the bootstrap default color, to distinguish it from TASK_FAILED.

The two getLabelClass functions were combined into one helper function in utils to avert confusion when changing these colors in the future.

@ssalinas
Copy link
Member

ssalinas commented Mar 29, 2016

Much easier to distinguish failed/lost from the killed tasks now. And +1 for consolidating the colors all to one place for these

@ssalinas ssalinas merged commit cec5000 into master Mar 29, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the TASK_KILLED-default-color-badges branch Mar 29, 2016
@Calvinp
Copy link
Contributor Author

Calvinp commented Mar 29, 2016

Thanks for the +1, though I'm not sure how well deserved it is on my part since I'm the one who split the colors in the first place.

@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.