Task badge color for TASK_KILLED is now default (grey) #970

Merged
merged 1 commit into from Mar 29, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Mar 24, 2016

The color for TASK_KILLED badges is now grey, the bootstrap default color, to distinguish it from TASK_FAILED.

The two getLabelClass functions were combined into one helper function in utils to avert confusion when changing these colors in the future.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Mar 29, 2016

Member

Much easier to distinguish failed/lost from the killed tasks now. And +1 for consolidating the colors all to one place for these

Member

ssalinas commented Mar 29, 2016

Much easier to distinguish failed/lost from the killed tasks now. And +1 for consolidating the colors all to one place for these

@ssalinas ssalinas merged commit cec5000 into master Mar 29, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the TASK_KILLED-default-color-badges branch Mar 29, 2016

@Calvinp

This comment has been minimized.

Show comment
Hide comment
@Calvinp

Calvinp Mar 29, 2016

Contributor

Thanks for the +1, though I'm not sure how well deserved it is on my part since I'm the one who split the colors in the first place.

Contributor

Calvinp commented Mar 29, 2016

Thanks for the +1, though I'm not sure how well deserved it is on my part since I'm the one who split the colors in the first place.

@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment