New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cleanup after bounce expire #975
Conversation
@tpetr are you cool with merging this? |
Found one thing here, seems that we can accidentally reuse instance number in this case. IF a task is cleaning we will currently reuse that instance number. If it then comes back out of cleaning, we will have a duplicate instance number. Not sure if that's an issue or not, will revisit this |
updated to not worry about the decommission/reactivation for now, causes more headaches than it's worth at the moment. Bounce expire was the real issue to start with anyways. |
@tpetr are you good with merging this one? causes a rather annoying problem for anyone without the change when canceling a bounce |
LGTM |
@tpetr initially did this so that it /fixes #972 . This will:
TASK_CLEANING
delete itIn addition I also did the same thing for the case where a decommissioned slave is reactivated (handled by SingularityCleaner), since right now reactivating the slave still requires all of the cleaning tasks to be properly cleaned and repalced, even though their slave is no longer deocmmissioning.
Thoughts on re-firing an event for the previous state vs creating a new event type for history updates that are deleted?