Remove cleanup after bounce expire#975
Merged
Merged
Conversation
Contributor
Author
|
@tpetr are you cool with merging this? |
Contributor
Author
|
Found one thing here, seems that we can accidentally reuse instance number in this case. IF a task is cleaning we will currently reuse that instance number. If it then comes back out of cleaning, we will have a duplicate instance number. Not sure if that's an issue or not, will revisit this |
Contributor
Author
|
updated to not worry about the decommission/reactivation for now, causes more headaches than it's worth at the moment. Bounce expire was the real issue to start with anyways. |
Contributor
Author
|
@tpetr are you good with merging this one? causes a rather annoying problem for anyone without the change when canceling a bounce |
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tpetr initially did this so that it /fixes #972 . This will:
TASK_CLEANINGdelete itIn addition I also did the same thing for the case where a decommissioned slave is reactivated (handled by SingularityCleaner), since right now reactivating the slave still requires all of the cleaning tasks to be properly cleaned and repalced, even though their slave is no longer deocmmissioning.
Thoughts on re-firing an event for the previous state vs creating a new event type for history updates that are deleted?