Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove cleanup after bounce expire #975
In addition I also did the same thing for the case where a decommissioned slave is reactivated (handled by SingularityCleaner), since right now reactivating the slave still requires all of the cleaning tasks to be properly cleaned and repalced, even though their slave is no longer deocmmissioning.
Thoughts on re-firing an event for the previous state vs creating a new event type for history updates that are deleted?
referenced this pull request
Mar 28, 2016
Found one thing here, seems that we can accidentally reuse instance number in this case. IF a task is cleaning we will currently reuse that instance number. If it then comes back out of cleaning, we will have a duplicate instance number. Not sure if that's an issue or not, will revisit this