New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cleanup after bounce expire #975

Merged
merged 4 commits into from Jun 7, 2016

Conversation

Projects
None yet
2 participants
@ssalinas
Member

ssalinas commented Mar 28, 2016

@tpetr initially did this so that it /fixes #972 . This will:

  • check that no other task cleanups are present (i.e. if task should still be in cleaning state)
  • if not, find the task history updates and if the last one is TASK_CLEANING delete it
  • re-fire an event for the previous state the task was in (most likely running)
  • make sure a pending request is put in the queue to take care of any other pending tasks or launched tasks that might need to be taken care of

In addition I also did the same thing for the case where a decommissioned slave is reactivated (handled by SingularityCleaner), since right now reactivating the slave still requires all of the cleaning tasks to be properly cleaned and repalced, even though their slave is no longer deocmmissioning.

Thoughts on re-firing an event for the previous state vs creating a new event type for history updates that are deleted?

@ssalinas ssalinas modified the milestone: 0.4.12 Apr 1, 2016

@ssalinas ssalinas added the hs_stable label Apr 4, 2016

@ssalinas ssalinas modified the milestones: 0.5.0, 0.6.0 Apr 5, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 28, 2016

Member

@tpetr are you cool with merging this?

Member

ssalinas commented Apr 28, 2016

@tpetr are you cool with merging this?

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas May 4, 2016

Member

Found one thing here, seems that we can accidentally reuse instance number in this case. IF a task is cleaning we will currently reuse that instance number. If it then comes back out of cleaning, we will have a duplicate instance number. Not sure if that's an issue or not, will revisit this

Member

ssalinas commented May 4, 2016

Found one thing here, seems that we can accidentally reuse instance number in this case. IF a task is cleaning we will currently reuse that instance number. If it then comes back out of cleaning, we will have a duplicate instance number. Not sure if that's an issue or not, will revisit this

@ssalinas ssalinas changed the title from Remove cleanup after bounce expire and slave reactivation to Remove cleanup after bounce expire May 9, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas May 9, 2016

Member

updated to not worry about the decommission/reactivation for now, causes more headaches than it's worth at the moment. Bounce expire was the real issue to start with anyways.

Member

ssalinas commented May 9, 2016

updated to not worry about the decommission/reactivation for now, causes more headaches than it's worth at the moment. Bounce expire was the real issue to start with anyways.

@ssalinas ssalinas modified the milestones: 0.6.0, 0.8.0 May 13, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Jun 7, 2016

Member

@tpetr are you good with merging this one? causes a rather annoying problem for anyone without the change when canceling a bounce

Member

ssalinas commented Jun 7, 2016

@tpetr are you good with merging this one? causes a rather annoying problem for anyone without the change when canceling a bounce

@tpetr

This comment has been minimized.

Show comment
Hide comment
@tpetr

tpetr Jun 7, 2016

Member

LGTM

Member

tpetr commented Jun 7, 2016

LGTM

@ssalinas ssalinas merged commit 7cc31cb into master Jun 7, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the bounce_expire branch Jun 7, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment