New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Task Overview on Task page #981

Merged
merged 7 commits into from Apr 28, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Apr 5, 2016

  • Removes taskId header on task page
  • Moves buttons (JSON, Kill task) to be in line with the breadcrumbs containing requestId and deployId
  • Adds instance number to those breadcrumbs.
  • Adds hostName to taskOverview well.
  • Changes task status in taskOverview well into a label.
  • Puts exit reason on the taskOverview well on its own line
Remove taskId header, move buttons to be in line with the breadcrumbs…
…. Add instanceNo to breadcrumbs. Add hostName to taskOverview well. Change task status into a label. Put exit reason on its own line

@Calvinp Calvinp changed the title from Improvements to Task Ovewview to Improvements to Task Ovewview on Task page Apr 5, 2016

@Calvinp Calvinp added the hs_staging label Apr 5, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 5, 2016

Member

Since it is no longer up top, can we get the rackId in another box down on the info section of the page? Unescaped version should be available in task.RackId . Other than that, looks good

Member

ssalinas commented Apr 5, 2016

Since it is no longer up top, can we get the rackId in another box down on the info section of the page? Unescaped version should be available in task.RackId . Other than that, looks good

@ssalinas ssalinas changed the title from Improvements to Task Ovewview on Task page to Improvements to Task Overview on Task page Apr 5, 2016

@Calvinp Calvinp added the hs_qa label Apr 6, 2016

ssalinas added some commits Apr 7, 2016

@ssalinas ssalinas modified the milestone: 0.6.0 Apr 11, 2016

@ssalinas ssalinas added the hs_stable label Apr 21, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 28, 2016

Member

Thanks for working with me on this @Calvinp , new task header section looks good

Member

ssalinas commented Apr 28, 2016

Thanks for working with me on this @Calvinp , new task header section looks good

@ssalinas ssalinas merged commit 93c39f4 into master Apr 28, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the more-obvious-task-number branch Apr 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment