Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tasks failed count for deploy failure info #984

Merged
merged 1 commit into from Apr 11, 2016
Merged

fix tasks failed count for deploy failure info #984

merged 1 commit into from Apr 11, 2016

Conversation

@ssalinas
Copy link
Member

@ssalinas ssalinas commented Apr 6, 2016

Since we allow a certain number of task retries on deploys, the tasks relevant for failure are those running when we actually decide that the deploy is failed. Before we were counting the total number failed (retried + currently running), but only reporting the failure info for the currently running ones we checked when the deploy failed. Now the count in the message will match the number of failure info items we return

@ssalinas ssalinas merged commit 31f870e into master Apr 11, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ssalinas ssalinas deleted the failed_count branch Apr 11, 2016
@ssalinas ssalinas removed hs_qa labels Apr 11, 2016
@ssalinas ssalinas modified the milestone: 0.6.0 Apr 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.