New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better failure message when creating a scheduled reqeust with no schedule #985

Merged
merged 1 commit into from Apr 11, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Apr 6, 2016

When creating a request, the API calls the method request.getQuartzScheduleSafe(). As it turns out, this method is not safe and throws an error when the schedule and quartzSchedule are not present. Now we check if those are present before calling getQuartzScheduleSafe().

I also intend to change getQuartzScheduleSafe() to either actually be safe, or at least not be misleading. Still working on exactly how to do that.

@Calvinp Calvinp added the hs_staging label Apr 6, 2016

@ssalinas ssalinas added the hs_qa label Apr 6, 2016

@ssalinas ssalinas added the hs_stable label Apr 7, 2016

@ssalinas ssalinas merged commit a0967a2 into master Apr 11, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the better-error-scheduled-reqeust-no-schedule branch Apr 11, 2016

@ssalinas ssalinas modified the milestone: 0.6.0 Apr 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment