No user isn't an admin user anymore - #991
Merged
Merged
Conversation
Contributor
|
👍 I can't think of a reason where having no user should allow you any admin actions |
Contributor
|
LGTM, thanks. Let's be sure to test out the endpoints that use this method in the test cluster to make sure there aren't any side effects. |
Contributor
|
On second thought, Unauthorized is the more correct response to return if the user is not present: http://stackoverflow.com/questions/3297048/403-forbidden-vs-401-unauthorized-http-responses I'd suggest copying what we do elsewhere and use the |
Contributor
|
🎈 |
Contributor
|
Thanks for the fix @Calvinp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin check would give you admin rights if you were logged in as no user.
This fixes that.
@tpetr please take a look - it is possible that there is a good reason for what Singularity was doing that I don't know about.