Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployProgress was undefined yet we tried to get attributes out of it #996

Merged
merged 1 commit into from Apr 20, 2016

Conversation

Calvinp
Copy link
Contributor

@Calvinp Calvinp commented Apr 14, 2016

This fixes a small bug that was triggered when looking at a request page within a few seconds of adding a new deploy to that request.
The deployProgress attribute of that deploy is not yet defined, yet Singularity tried to get timestamp and deployStepWaitTimeMs out of it, causing an error to be logged to the console.

@ssalinas
Copy link
Member

👍 thanks for the fix @Calvinp

@ssalinas ssalinas modified the milestone: 0.6.0 Apr 15, 2016
@ssalinas
Copy link
Member

LGTM

@ssalinas ssalinas merged commit eb5e40d into master Apr 20, 2016
@ssalinas ssalinas deleted the fix-undefined-on-request-page-after-deploy branch April 20, 2016 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants