New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployProgress was undefined yet we tried to get attributes out of it #996

Merged
merged 1 commit into from Apr 20, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Apr 14, 2016

This fixes a small bug that was triggered when looking at a request page within a few seconds of adding a new deploy to that request.
The deployProgress attribute of that deploy is not yet defined, yet Singularity tried to get timestamp and deployStepWaitTimeMs out of it, causing an error to be logged to the console.

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 14, 2016

Member

👍 thanks for the fix @Calvinp

Member

ssalinas commented Apr 14, 2016

👍 thanks for the fix @Calvinp

@Calvinp Calvinp added the hs_staging label Apr 14, 2016

@ssalinas ssalinas modified the milestone: 0.6.0 Apr 15, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 20, 2016

Member

LGTM

Member

ssalinas commented Apr 20, 2016

LGTM

@ssalinas ssalinas merged commit eb5e40d into master Apr 20, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@ssalinas ssalinas deleted the fix-undefined-on-request-page-after-deploy branch Apr 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment