Fix to enable buttons on dashboard paused requests table #998

Merged
merged 3 commits into from Apr 20, 2016

Conversation

Projects
None yet
2 participants
@Calvinp
Contributor

Calvinp commented Apr 15, 2016

The required functionality was not implemented.

@ssalinas ssalinas modified the milestone: 0.6.0 Apr 15, 2016

SingularityUI/app/views/dashboard.coffee
+ id = $(e.target).parents('tr').data 'request-id'
+ request = @getRequest id
+ unless request
+ console.error ("Could not find request #{id}. Perhaps someone removed it?")

This comment has been minimized.

@ssalinas

ssalinas Apr 15, 2016

Member

A console.error would hide this error from anyone without the console open. To most it would look like it just wasn't working and they might keep clicking. Let's keep this message, but use something like Messenger().error instead (see application.coffee for an example). This will give a little dispersible message telling the user went wrong.

@ssalinas

ssalinas Apr 15, 2016

Member

A console.error would hide this error from anyone without the console open. To most it would look like it just wasn't working and they might keep clicking. Let's keep this message, but use something like Messenger().error instead (see application.coffee for an example). This will give a little dispersible message telling the user went wrong.

This comment has been minimized.

@Calvinp

Calvinp Apr 15, 2016

Contributor

Fixed

@Calvinp

Calvinp Apr 15, 2016

Contributor

Fixed

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 15, 2016

Member

👍

Member

ssalinas commented Apr 15, 2016

👍

@Calvinp Calvinp added the hs_stable label Apr 19, 2016

@ssalinas

This comment has been minimized.

Show comment
Hide comment
@ssalinas

ssalinas Apr 20, 2016

Member

Thanks for the fix @Calvinp

Member

ssalinas commented Apr 20, 2016

Thanks for the fix @Calvinp

@ssalinas ssalinas merged commit 52733a5 into master Apr 20, 2016

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ssalinas ssalinas deleted the fix-dashboard-paused-requests-table branch Apr 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment