Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Connected" Component generated by
connect
inherits propTypes unrelated to the store dependencies from the BaseComponent.So if a Component passed to
connect
declares acount
propType and there is notcount
field in the dependency...That Component returned by
connect
will have a propType signature like...Previously the connected component would only receive the types defined in it's dependencies without any additionally types from the BaseComponent. This can be problematic if propTypes are used as a programatic interface in parent components. Perhaps not common, but relevant for some.
TODOs
src/GeneralStore.js
package.json
andbower.json
CHANGELOG.md
is up to date