New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating v1.0.2 to v.1.2.3 - Some Ajax calls not completing #509
Comments
Yes, this happens to me too. |
@mugnap Do you have any idea what causes it, any work around found? I will make a jsfiddle now |
No, I have no idea of the causes and unfortunately I did not have time to debug it, so I simply rolled back to previous version. -------- Messaggio originale --------Da: Euan Gordon <notifications@github.com>Data: mer 16 dic 2020, 11:13A: CodeByZach/pace <pace@noreply.github.com>Cc: mugnap <paolo.mugnaini@gmail.com>, Mention <mention@noreply.github.com>Oggetto: Re: [CodeByZach/pace] Updating v1.0.2 to v.1.2.3 - Some Ajax calls not completing (#509)
@mugnap Do you have any idea what causes it, any work around found? I will make a jsfiddle now
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
|
I confirm. I have the same problem. This code does not transfer control to
After returning to version 1.0.2 - everything works fine |
Having the same issue here. Really complicated to debug, since this does not happen each time (for the same event sometimes the success() callback is called, sometimes not...). Revert to 1.0.2 : fine again ! |
I can get it to happen everytime, but I couldn't get a jsfiddle to connect to my API due to CORS :( |
I have the very same problem |
Hi @euangordon, Could you please elaborate on this? Would very much like to work on getting this resolved. Thank you! |
jQuery uses:
Which is completely overwritten by Pace:
I have rewritten
I can create a pull-request if you want. |
Please do. |
A few observations:
|
Found it: #230 |
obj["on" + event] was overwritten also when addEventListener was available. Now adding an event fallback when addEventListener is unavailable. The original event (when available) is first added to the list, and then one or more callbacks are added. Fixes CodeByZach#509 Signed-off-by: Luuk Bosma <l.bosma@interay.com>
Hi All, |
Problem solved on my side too, thanks! |
Thanks for the good job. The new version (1.2.4) works fine for me! |
Hi,
I have been using v1.0.2 for some time, but started noticing issues with Firefox keeping Pace.js running even after the page has loaded. I know this has been recorded and should be fixed in v1.2.3.
After upgrading to v1.2.3, I now see that some of my AJAX get calls are not working properly. The API gets hit and returns data, but I never get into the Ajax success or error. I can get it to fail consistently for some calls, but others to the same API work fine. So I wonder if it is larger datasets that are causing the issue?
Rolling back to v1.0.2 and my AJAX calls are back working but the FF issue persists.
My paceOptions:
paceOptions = { ajax: { trackMethods: ['GET', 'POST', 'DELETE', 'PUT', 'PATCH'], ignoreURLs: ['mouseflow', 'mainHub', '__browserLink', 'browserLinkSignalR', 'ServiceBusTopicHub', 'signalr'], trackWebSockets: false } }
In the below code, it sometimes never enters the success or error when using v1.2.3, but always works using v1.0.2
The text was updated successfully, but these errors were encountered: