Review French translation #5002

vincentfretin · 2022-01-08T11:12:37Z

After seeing an error in the French translation for the remix button, should be Remixer infinitive and not Remixé, I did a quick review of the whole json file. There are also some non translated strings, but I didn't translate those.

cc @ssm2017 @cbo04

cbo04

Suggestions for the whole file:

replace "optional" by "facultatif"
replace "custom" by "personnalisé"
check the caps inside text strings (should be "Chercher des scènes" instead of "Chercher des Scènes" or "Salles favorites" instead of "Salles Favorites")

Specific lines:

72/73 replace "Positional audio" by "Audio spatialisé"
329 replace "prendre une photo" by "a pris une photo"
369 replace "Qualité du matériau" by "Qualité des surfaces (Materials)"
535 replace "Joindre la salle" by "Rejoindre la salle"

I don't know how to translate all the lines related to the RTC debug panel (439 > 461) and not sure if needed to be translated.

src/assets/locales/fr.json

vincentfretin · 2022-01-08T14:20:11Z

Thanks @cbo04 for the feedbacks. I fixed all you said normally.

… in this message

vincentfretin · 2022-01-08T16:04:57Z

@cbo04 I did a lot more changes, I resynced the json with the updated en.json I just recreated. It's little bit tedious to compare and update when you are used to po files in other projects, ah ha.
I splitted the changes in several commits for an easier review. I'll appreciate any review on the new translations.

src/assets/locales/fr.json

vincentfretin · 2022-01-08T16:15:42Z

src/assets/locales/fr.json

  "discord-page.secondary-tagline": "Aucun téléchargement ni inscription. Totalement disponible en VR.",
  "discord-page.splash-tag": "Conçu pour vos projets les plus importants.",
+  "empty-token.title": "Jetons API",
+  "empty-token.title2": "Liste des jetons",


"empty-token.title": "API Tokens",
"empty-token.title2": "Token List",

src/assets/locales/fr.json

vincentfretin · 2022-01-08T16:18:30Z

src/assets/locales/fr.json

+  "revoke-token-modal.revoke-warning-2": "permanente",
+  "revoke-token-modal.revoke-warning-3": "et",
+  "revoke-token-modal.revoke-warning-4": "ne peut être annulée.",
+  "revoke-token-modal.title": "Revoquer jeton",


"revoke-token-modal.cancel": "Cancel",
"revoke-token-modal.description1": "Are you sure you want to revoke this token?",
"revoke-token-modal.description2": "Any scripts or requests relying on this token will lose access.",
"revoke-token-modal.revoke": "Revoke",
"revoke-token-modal.revoke-warning-1": "This action is",
"revoke-token-modal.revoke-warning-2": "permanent",
"revoke-token-modal.revoke-warning-3": "and",
"revoke-token-modal.revoke-warning-4": "can not be undone.",
"revoke-token-modal.title": "Revoke token",

vincentfretin · 2022-01-08T16:18:42Z

src/assets/locales/fr.json

+  "save-api-token.description2": "Vous ne serez pas en mesure de le voir de nouveau une fois que vous aurez fermé cette fenêtre.",
+  "save-api-token.revoke": "Confirmer et fermer",
+  "save-api-token.scopes": "Portées d'accès",
+  "save-api-token.title": "Jeton API",


"save-api-token.copied": "Copied",
"save-api-token.copy-label": "API Token",
"save-api-token.description1": "Please save this API token in a safe place.",
"save-api-token.description2": "You will not be able to see it again once you have closed this window.",
"save-api-token.revoke": "Confirm and close",
"save-api-token.scopes": "Scopes",
"save-api-token.title": "API Token",

Suggested change

"save-api-token.title": "Jeton API",

"save-api-token.title": "Jeton d'API",

vincentfretin · 2022-01-08T16:18:57Z

src/assets/locales/fr.json

  "scene-url-modal.title": "URL d'une scène personnalisée",
  "scene-url-modal.url-input": "URL d'une scène",
  "select-input-field.placeholder": "Sélectionner...",
+  "share-popover.source.avatar-camera": "Caméra de l'avatar",


"share-popover.source.avatar-camera": "Avatar Camera",

vincentfretin · 2022-01-08T16:19:16Z

src/assets/locales/fr.json

+  "tokens.no-access-description2": "Si vous pensez que vous devriez avoir accès à cette page, veuillez demander des privillèges supplémentaires à votre administrateur Hubs.",
+  "tokens.no-tokens-created": "Aucun jeton créé.",
+  "tokens.revoke-token": "Revoquer",
+  "tokens.scopes": "Portées d'accès",


"token-type.account-token": "Account Token",
"token-type.app-token": "App Token",
"tokens.administrator-privileges-required": "Administrator privileges required",
"tokens.button-create-token": "Create token",
"tokens.create-tokens-description": "Create tokens to access the",
"tokens.create-tokens-description-hubs-api": "Hubs API",
"tokens.no-access-description1": "You do not have sufficient privileges to create API tokens.",
"tokens.no-access-description2": "If you believe you should have access to this page, please request privileges from your Hubs administrator.",
"tokens.no-tokens-created": "No tokens created.",
"tokens.revoke-token": "Revoke",
"tokens.scopes": "Scopes",

vincentfretin · 2022-01-08T16:22:03Z

Just click on Resolve conversation for a given comment if you agree on the translations. Thanks.

src/assets/locales/fr.json

vincentfretin · 2022-01-08T18:56:06Z

For the different new audio settings

Activer l'audio clipping
Seuil pour l'audio clipping
Désactiver le panning audio gauche/droite

If you have something better...

By the way for
"Désactiver le contrôle automatique du gain du micro"
Does it make sense in French? I don't think so... https://www.larousse.fr/dictionnaires/francais/gain/35820
Technically gain is controlling the volume here. In GNOME the French translation for controlling the mic input is "Volume d'entrée".
I changed it to
"Désactiver le contrôle automatique du volume du micro"
in 2d6a830

vincentfretin · 2022-01-08T19:20:12Z

I fixed another i18n issue in the invite popover for the "Enter code in hubs.link" message, see the updated French screenshots for the More menu and invite popover in #5003
I translated it to "Code à saisir sur hubs.link"

cbo04

Good job @vincentfretin ! Thank you!

src/assets/locales/fr.json

cbo04 · 2022-01-08T19:39:11Z

Just click on Resolve conversation for a given comment if you agree on the translations. Thanks.

Maybe @ioioioio @Slayug @ssm2017 @robertlong would like to have a look before we close your comments.

vincentfretin · 2022-01-08T20:13:53Z

@cbo04 I think I changed everything you commented on. Thanks again.

src/assets/locales/fr.json

any-lia · 2022-01-11T21:35:55Z

src/assets/locales/fr.json

  "more-menu.whats-new": "Quoi de neuf",
-  "oauth-screen.description": "Vous devrez vous connecter pour {provider} accéder à la salle.",
+  "more-menu.you": "Vous",
+  "more-menu.you-signed-in-as": "Vous (connecté(e) en tant que {email})",


Why is there parenthesis ?

English was "You (Signed in as: {email})"
What would you want instead, a comma? "Vous, connecté(e) en tant que {email}" ?

That's already better, maybe with a verb: Vous êtes connecté(e) en tant que {email}

While it's good translation if it was used as a sentence, here it's used mainly as a title for a group of links, see screenshot #5003 (comment)
so I still prefer with the parentheses. What do others think?

isn't it linked to Spoke? to be sure of the account used?

Not really related to Spoke, but yes you can be sure with which email you are connected. Screenshot when connected:

Or maybe just: Connecté(e) en tant que {email} there is not so much space to print the full sentence.
Even if it's not like the english version we keep the sense and we there is not a lot of space.

requesting a change here:

the string should be "header.signed-in-as" with it's default string being "Signed in as {email}"
For "You", I believe that is going to be "people-sidebar.person-name.you"

See #5003 this part wasn't internationalized yet. All messages in this More menu, even the headers "Room" and "Support" are using the "more-menu." dotted name.
Separating the "You" and "Signed in as {email}" in different messages doesn't seem to be a good idea to me, because you will hard code the parentheses in the code? Some language may not really use parentheses for this. And be careful to right to left languages too. :)

Thanks for the clarification, I didn't see the separate PR's but I will take a look. I think we should drop the parens and the word 'you' altogether if we are going to make changes at that level.

any-lia · 2022-01-11T21:40:25Z

src/assets/locales/fr.json

  "preferences-screen.material-quality-setting.medium": "Medium",
  "preferences-screen.preference.allow-multiple-hubs-instances": "Désactiver la sortie automatique quand de multiples instances de hubs sont ouvertes",
  "preferences-screen.preference.animate-waypoint-transitions": "Animer les transitions entre les waypoints",
+  "preferences-screen.preference.audio-clipping-threshold": "Seuil pour l'audio clipping",


Suggested change

"preferences-screen.preference.audio-clipping-threshold": "Seuil pour l'audio clipping",

"preferences-screen.preference.audio-clipping-threshold": "Seuil de coupure audio",

any-lia · 2022-01-11T21:48:30Z

src/assets/locales/fr.json

+  "new-token.select-scopes-title": "Sélectionner les portées d'accès",
+  "new-token.title": "Nouveau jeton",
+  "new-token.token-type": "Type de jeton",
+  "new-token.warning-at-least-one-scope": "Veuillez sélectionner au moins une portée d'accès.",


Suggested change

"new-token.warning-at-least-one-scope": "Veuillez sélectionner au moins une portée d'accès.",

"new-token.warning-at-least-one-scope": "Veuillez sélectionner au moins un périmètre d'accès.",

any-lia · 2022-01-11T21:49:01Z

src/assets/locales/fr.json

+  "new-token.back": "Retour",
+  "new-token.generate": "Générer",
+  "new-token.select-scopes-description": "Régler le niveau d'accès de ce jeton en choisissant dans la liste des portées d'accès.",
+  "new-token.select-scopes-title": "Sélectionner les portées d'accès",


Suggested change

"new-token.select-scopes-title": "Sélectionner les portées d'accès",

"new-token.select-scopes-title": "Sélectionner les périmètres d'accès",

any-lia · 2022-01-11T21:49:43Z

src/assets/locales/fr.json

+  "tokens.no-access-description2": "Si vous pensez que vous devriez avoir accès à cette page, veuillez demander des droits supplémentaires à votre administrateur Hubs.",
+  "tokens.no-tokens-created": "Aucun jeton créé.",
+  "tokens.revoke-token": "Révoquer",
+  "tokens.scopes": "Portées d'accès",


Suggested change

"tokens.scopes": "Portées d'accès",

"tokens.scopes": "Périmètres d'accès",

src/assets/locales/fr.json

any-lia · 2022-01-11T22:03:55Z

Good jobs @vincentfretin @cbo04 @jajoe

I have done some suggestions and changed porté (from scope) by Périmètre it's close to the original sense.

But I'm still not sure about the audio clipping, do you agree to say, Audio Clipping Threshold is a sound reduction or the minimum detection audio to enable the mic (like Discord with the input sensitivity) ?

src/assets/locales/fr.json

vincentfretin · 2022-01-12T07:42:12Z

For audio clipping, I'm not sure what it does, this may be related to the mic volume sensitivity like you said. We should look at the code to be sure or someone can answer that here.

For scope, when talking about JWT, I see generally it translated with "portée", not "périmètre", some French documentation I found that talk about JWT:
https://docs.aws.amazon.com/fr_fr/apigateway/latest/developerguide/apigateway-enable-cognito-user-pool.html
https://docs.oracle.com/fr-fr/iaas/Content/APIGateway/Tasks/apigatewayusingjwttokens.htm
https://oa.dnc.global/-fr-.html?page=unarticle&id_article=11

Co-authored-by: Alexandra <bug.graph@gmail.com>

any-lia · 2022-01-12T08:49:25Z

You're right, it's better to use common use for portée.

I will try to check the code for audio clipping.

vincentfretin · 2022-01-12T13:44:33Z

For the remaining audio debug panel messages:

If you are inspired to translate all all. All the terms are related to PannerNode
https://developer.mozilla.org/en-US/docs/Web/API/PannerNode
The MDN page is not translated into French :)

matthewbcool

Great work! Thanks for helping make the french language translation the most complete localization of Hubs. I have a few suggested changes to make before we merge this in.
Line 573 and 313-314
Thank you again for your contributions.

src/assets/locales/fr.json

matthewbcool · 2022-01-12T19:22:39Z

src/assets/locales/fr.json

  "more-menu.whats-new": "Quoi de neuf",
-  "oauth-screen.description": "Vous devrez vous connecter pour {provider} accéder à la salle.",
+  "more-menu.you": "Vous",
+  "more-menu.you-signed-in-as": "Vous (connecté(e) en tant que {email})",


requesting a change here:

the string should be "header.signed-in-as" with it's default string being "Signed in as {email}"
For "You", I believe that is going to be "people-sidebar.person-name.you"

matthewbcool · 2022-01-12T19:26:55Z

src/assets/locales/fr.json

+  "preferences-screen.preference.lazy-load-scene-media": "Activer le chargement asynchrone des ressources multimédia de la scène",
  "preferences-screen.preference.locale": "Langue",
-  "preferences-screen.preference.material-quality-setting": "Qualité du matériau",
+  "preferences-screen.preference.material-quality-setting": "Qualité des textures",


This refers to materials/textures. e.g Low quality will not display metallic, roughness and normal maps.

src/assets/locales/fr.json

vincentfretin · 2022-01-13T10:31:57Z

I replied to some comments, but I don't see the replies :(
I'm replying again.

"preferences-screen.preference.material-quality-setting": "Qualité des textures",
This refers to materials/textures. e.g Low quality will not display metallic, roughness and normal maps.

Thanks for confirming. So I think the translation is still good, adding metallic, roughness and normal maps modify the rendering of the basic texture, so still good. Generally in games you see this translation as well.

About the "more-menu.you-signed-in-as": "Vous (connecté(e) en tant que {email})",
and

requesting a change here:
the string should be "header.signed-in-as" with it's default string being "Signed in as {email}"
For "You", I believe that is going to be "people-sidebar.person-name.you"

This part wasn't internationalized, I fixed it in #5003
Separating "You" and "Signed in as {email}" in different messages doesn't seem a good idea to me, because you will hard code the parentheses in the code right? Some languages may use something different than parentheses to convey this information, also be careful to right to left languages.
The "Room" and "Support" headers currently use the dotted name "more-menu." like the other entries in the menu.
Unless you want to change the dotted name for "Room" and "Support", and change the key in all current json files?

matthewbcool · 2022-01-13T10:46:34Z

#5002 (comment)
One possible change we can consider: removing "You" and the parens from the more menu #5003. We can discuss this in #5003

vincentfretin added 2 commits January 8, 2022 12:06

Review French translation

f1c70c9

fix camera and screen French translation

82b4c29

cbo04 suggested changes Jan 8, 2022

View reviewed changes

src/assets/locales/fr.json Outdated Show resolved Hide resolved

src/assets/locales/fr.json Outdated Show resolved Hide resolved

src/assets/locales/fr.json Outdated Show resolved Hide resolved

vincentfretin added 2 commits January 8, 2022 15:06

lowercase salle, favorite, scène

bb5e487

more changes in the French translation from feedbacks

0fe7f49

vincentfretin added 11 commits January 8, 2022 15:23

additional translations

5575add

more lowercase

02e186a

fix joined-room translation

6fc47df

oups, don't make a typo for new translation...

863c5a4

fix photo-message.default-tweet translation, there is no url variable…

c6eac84

… in this message

same for video-message.default-tweet

2bc87ae

fix talking/not talking translation

8598d3e

fix oauth connection with provider translation

6383815

space before ':'

d939a5a

remove messages that doesn't exist anymore

9f23dc4

new messages after resync with en.json

0dac294

vincentfretin commented Jan 8, 2022

View reviewed changes

src/assets/locales/fr.json Show resolved Hide resolved

vincentfretin commented Jan 8, 2022

View reviewed changes

fix bad translation for sign up

5a43021

vincentfretin commented Jan 8, 2022

View reviewed changes