Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: favor CSS over syleguide components SearchPost.vue #3377

Merged
merged 4 commits into from Apr 7, 2020
Merged

refactor: favor CSS over syleguide components SearchPost.vue #3377

merged 4 commits into from Apr 7, 2020

Conversation

mattwr18
Copy link
Member

@cypress
Copy link

cypress bot commented Mar 30, 2020 •
edited


Test summary

66 • 0 • 0 • 0

Run details
Project Human-Connection
Status Passed
Commit ca5c1a5
Started Apr 7, 2020 2:13 PM
Ended Apr 7, 2020 2:34 PM
Duration 21:26 💡
OS Linux Ubuntu Linux - 16.04
Browser Firefox 68

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Mar 30, 2020 •
edited


Test summary

66 • 0 • 0 • 0

Run details
Project Human-Connection
Status Passed
Commit 3ca4885 ℹ️
Started Apr 7, 2020 2:14 PM
Ended Apr 7, 2020 2:39 PM
Duration 24:17 💡
OS Linux Ubuntu Linux - 16.04
Browser Firefox 68

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mattwr18 mattwr18 changed the title refactor: favor CSS over syleguide components refactor: favor CSS over syleguide components PostCard.vue Mar 31, 2020
@alina-beck alina-beck changed the title refactor: favor CSS over syleguide components PostCard.vue refactor: favor CSS over syleguide components SearchPost.vue Apr 7, 2020
alina-beck
alina-beck approved these changes Apr 7, 2020
View reviewed changes
Copy link
Collaborator

@alina-beck alina-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool improvement @mattwr18! 😎

I took it one step further and added a commit to use the CounterIcon component to display the counts. It needed just a little tweaking... What do you think? If you're happy, I'm happy and we can merge! 😁

@mattwr18
Copy link
Member Author

mattwr18 commented Apr 7, 2020

Looks good to me @alina-beck ... in case anyone else wants a quick look at the slightly new design
Screenshot from 2020-04-07 15-14-07

mattwr18 and others added 4 commits April 7, 2020 15:41
@mattwr18
refactor: favor CSS over syleguide components
ff44fdb
@mattwr18
fix(frontend): update tests with new CSS selectors
668159f
@alina-beck @mattwr18
use CounterIcon component to show counts
797efe0 
- also adds a 'soft' variant to CounterIcon to make it more adaptable
@mattwr18
chore: update variable to avoid validation error
ca5c1a5 
- test was throwing a validation error for count as searchResults was
  setting commentCount instead of commentsCount
@mattwr18 mattwr18 force-pushed the 3376-refactor-SearchPost-component branch from 3f90ce5 to ca5c1a5 Compare April 7, 2020 13:41
@mattwr18 mattwr18 merged commit a713844 into master Apr 7, 2020
@mattwr18 mattwr18 deleted the 3376-refactor-SearchPost-component branch April 7, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alina-beck alina-beck alina-beck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔧 [Refactor] Remove ds-flex from SearchPost/refactor
2 participants
@mattwr18 @alina-beck