🐛 [Bug] : long comments can be folded up and down #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogerly
changed the title
added 5 commits
June 21, 2019 13:11
roschaefer
previously requested changes
Jun 24, 2019
There was a problem hiding this comment.
I think that's a great idea and creates a lot of better user experience. Think of all the lengthy comments that certain people write. So this helps a lot.
The change I would request is to encapsulate the logic for folding and unfolding into a separate component so we could use it at other places, too. Also a component test would be nice!
Tirokk
requested changes
Jun 28, 2019
…nnection into 844-Comments-cannot-be-expanded-if-they-are-too-long
|
should we pair on testing this @ogerly |
Tirokk
approved these changes
Jul 3, 2019
Tirokk
dismissed
roschaefer’s stale review
The most important changes are done in my eyes … others for the soon future.
|
Please pull in the master, than I will merge … |
Codecov Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
long comments can be folded up and down
Issues
fixes 🐛 [Bug] Comments cannot be expanded if they are too long #844
None
Todo