New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Draft" Dialog when saving contribution #300

Closed
appinteractive opened this Issue Sep 24, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@appinteractive
Collaborator

appinteractive commented Sep 24, 2018

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Checkout develop (or use staging)
  2. Create a contribution
  3. Try to save

Expected behavior
No "Draft" dialog should appear and we should see the saved contribution

Screenshots
kapture 2018-09-24 at 11 42 32

Appeared after mergin #258
@ionphractal

@ionphractal

This comment has been minimized.

Show comment
Hide comment
@ionphractal

ionphractal commented Sep 24, 2018

@appinteractive
oops, will fix

@roschaefer

This comment has been minimized.

Show comment
Hide comment
@roschaefer

roschaefer Oct 1, 2018

Contributor

closed via #306

Contributor

roschaefer commented Oct 1, 2018

closed via #306

@appinteractive

This comment has been minimized.

Show comment
Hide comment
@appinteractive

appinteractive Oct 1, 2018

Collaborator

@roschaefer this was already fixed!?

Collaborator

appinteractive commented Oct 1, 2018

@roschaefer this was already fixed!?

@roschaefer

This comment has been minimized.

Show comment
Hide comment
@roschaefer

roschaefer Oct 1, 2018

Contributor

@appinteractive well, I just removed the behaviour for contributions and kept it for comments.

Contributor

roschaefer commented Oct 1, 2018

@appinteractive well, I just removed the behaviour for contributions and kept it for comments.

@roschaefer

This comment has been minimized.

Show comment
Hide comment
@roschaefer

roschaefer Oct 1, 2018

Contributor

@appinteractive it's a temporary solution. I want to merge develop into master before we implement more features

Contributor

roschaefer commented Oct 1, 2018

@appinteractive it's a temporary solution. I want to merge develop into master before we implement more features

@appinteractive

This comment has been minimized.

Show comment
Hide comment
@appinteractive

appinteractive Oct 1, 2018

Collaborator

Okay I see the #300 which fixes it was not merged until now.

Collaborator

appinteractive commented Oct 1, 2018

Okay I see the #300 which fixes it was not merged until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment