-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: LEAP-878: Fix shrinking textarea on edit (#5665)
We have TextArea's HtxTextBox (input when you edit text block) updating its height on edit. That was to auto-increase height of multiline blocks. But we stopped taking borders into account some time ago (HumanSignal/label-studio-frontend@c8417d5). Returning it back and fixing condition for empty scrollHeight fixes shrinking input. + fix position for "Delete Region" icon — it's in the middle now <img width="486" alt="Screenshot 2024-04-03 at 16 02 11" src="https://github.com/HumanSignal/label-studio/assets/1607227/fe3fae2d-4006-413f-aa4e-5dd0991f68e8"> ### PR fulfills these requirements - [ ] Tests for the changes have been added/updated - [ ] Docs have been added/updated - [ ] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.) - [x] Self-reviewed and ran all changes on a local instance ### Describe the reason for change Inputs and textareas used to edit `TextArea` tag text blocks were shrinking every time you type something into them. ### This change affects (describe how if yes) - [ ] Performance - [ ] Security - [x] UX ### Does this PR introduce a breaking change? - [ ] Yes, and covered entirely by feature flag(s) - [ ] Yes, and covered partially by feature flag(s) - [x] No - [ ] Not sure (briefly explain the situation below) ### What level of testing was included in the change? - [ ] e2e (codecept) - [ ] integration (cypress) - [ ] unit (jest) --------- Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com> Co-authored-by: hlomzik <hlomzik@users.noreply.github.com>
- Loading branch information
1 parent
1ab1ee9
commit 6b28a6d
Showing
9 changed files
with
27 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "fix: LEAP-849: LEAP-933: Security vulnerability fixes", | ||
"commit": "f0086f25c287f6efc5e27acd87bb0587f0316a3f", | ||
"date": "2024-04-09T17:49:03.000Z", | ||
"branch": "fb-leap-849" | ||
"message": "Merge branch 'develop' into 'fb-leap-878/textarea-height'", | ||
"commit": "b658f627980cf5816a20682b1a529c7273a1ee86", | ||
"date": "2024-04-09T19:14:55.000Z", | ||
"branch": "fb-leap-878/textarea-height" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "fix: LEAP-849: LEAP-933: Security vulnerability fixes", | ||
"commit": "f0086f25c287f6efc5e27acd87bb0587f0316a3f", | ||
"date": "2024-04-09T17:49:03.000Z", | ||
"branch": "fb-leap-849" | ||
"message": "Merge branch 'develop' into 'fb-leap-878/textarea-height'", | ||
"commit": "b658f627980cf5816a20682b1a529c7273a1ee86", | ||
"date": "2024-04-09T19:14:55.000Z", | ||
"branch": "fb-leap-878/textarea-height" | ||
} |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"message": "fix: LEAP-849: LEAP-933: Security vulnerability fixes", | ||
"commit": "f0086f25c287f6efc5e27acd87bb0587f0316a3f", | ||
"date": "2024-04-09T17:49:03.000Z", | ||
"branch": "fb-leap-849" | ||
"message": "Merge branch 'develop' into 'fb-leap-878/textarea-height'", | ||
"commit": "b658f627980cf5816a20682b1a529c7273a1ee86", | ||
"date": "2024-04-09T19:14:55.000Z", | ||
"branch": "fb-leap-878/textarea-height" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters