Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ByteSize should implement IComparable #292

Closed
Vloodz opened this issue Jun 6, 2014 · 2 comments · Fixed by #294
Closed

ByteSize should implement IComparable #292

Vloodz opened this issue Jun 6, 2014 · 2 comments · Fixed by #294

Comments

@Vloodz
Copy link

Vloodz commented Jun 6, 2014

When adding ByteSize objects to a DataTable sorting doesn't work. This can be fixed by implenting IComparable, which can be done in just a few lines of code.

See the following link for more info:
http://stackoverflow.com/questions/24087735/make-a-datatable-sort-by-an-objects-compareto-method

@MehdiK
Copy link
Member

MehdiK commented Jun 11, 2014

I will be honest with you: I don't promise to add this in, as supporting DataTable is not a goal of this framework. That said I am interested to see what's involved. So send a PR and we will check it out. Thanks.

@MehdiK
Copy link
Member

MehdiK commented Jun 11, 2014

@Vloodz the support is being added. @mexx to the rescue as usual!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants