Permalink
Commits on May 17, 2016
  1. replace blead with 5.24 in .travis.yml, as blead is unknown

    leejo committed May 17, 2016
  2. bump VERSION and Changes for CPAN release

    leejo committed May 17, 2016
Commits on May 12, 2016
  1. G3S -> Humanstate

    leejo committed May 12, 2016
Commits on Jan 7, 2016
  1. update README.md

    leejo committed Jan 7, 2016
  2. remove URL query params from output profiles

    leejo committed Jan 7, 2016
    stops confusion when trying to get to the profile from the list of
    files under /nytprof (as the original query params would otherwise
    have to be URL encoded, possibly twice to keep them). it's easiest
    to just get rid of them instead of adding lots of escaping hackery
    to the code
Commits on Nov 28, 2015
  1. Merge pull request #11 from zoffixznet/fix-typo

    leejo committed Nov 28, 2015
    Fix typo
  2. resolve #10 - skip tests if nytprofhtml can't be found

    leejo committed Nov 28, 2015
    as the path to nytprofhtml can be set in the config file it's not
    essential that we run the tests to the assumed nytprofhtml given
    that might not be the one used. if we can't find it in testing then
    skip tests - refactor the search to a subroutine so we can call it
    from the tests
Commits on Oct 21, 2015
  1. move github repo to G3S org

    leejo committed Oct 21, 2015
Commits on Aug 18, 2015
  1. ref #5 - some refactoring after investigation

    leejo committed Aug 18, 2015
    there is a timing bug when the plugin is called multiple times (in
    the order of tens of thousands of times). having dug a bit the slow
    down is related to calling DB::enable_profile and only because
    we are passing in a custom file name, i.e. something low level in
    Devel::NYTProf itself. if we comment out that line or remove the
    file name argument from the call to DB::enable_profile there is
    no slow down.
    
    there's nothing we can do here. we could perhaps raise a bug/test
    case with Devel::NYTProf but given the use case for this bug i
    doubt it will be a priority. looking at the source for Devel::NYTProf
    i see this block[1] gets executed when a file is passed into
    DB::enable_profile so the bug is somewhere around that chunk of
    code and possibly in the close_output_file[2] function
    
    (thinking out loud here: is it possible that we are cumulatively
    adding to the original file, and each time the plugin runs and we
    change the filename we are adding a bit more to it? I'm not sure
    that's the bug given we give the start=no argument to Devel::NYTProf,
    so it *shouldn't* be profiling anything *until* we call
    DB::enable_profile)
    
    having done some investigation here noticed that the file argument
    in the startup is redundant, so remove it. can also refactor out a
    few lines in prior to the DB::finish_profile call
    
    [1] https://github.com/timbunce/devel-nytprof/blob/a520cac8949d94b9301df974822ccdbb32104d7a/NYTProf.xs#L2991
    
    [2] https://github.com/timbunce/devel-nytprof/blob/a520cac8949d94b9301df974822ccdbb32104d7a/NYTProf.xs#L1869
Commits on Aug 4, 2015
  1. resolve #9 - fix Win32 filename test to not hand

    leejo committed Aug 4, 2015
    seems that setting $^O too early interferes with the testing fork
    handling (or something) on some platforms, so do this in a hook to
    work around this
  2. Merge branch 'xlat-master'

    leejo committed Aug 4, 2015
Commits on Aug 3, 2015
  1. resolve #6 - fixes for : and = on Win32 platforms

    leejo committed Aug 3, 2015
    escape the chars so this doesn't break due to Win32 platforms using
    : and = chars in different ways to Unix like platforms
    
    Squashed commit of the following:
    
    commit fc467d7
    Author: Nicolas GEORGES <nicolas54.georges@gmail.com>
    Date:   Mon Aug 3 15:16:06 2015 +0200
    
        refs #6 - fix unit tests on mswin32 plateforms
Commits on Jun 4, 2015
Commits on Feb 27, 2015
  1. README update for VERSION

    leejo committed Feb 27, 2015
Commits on Feb 25, 2015
  1. Mojolicious v6.00 compatibility fixes

    leejo committed Feb 25, 2015
    ->render_not_found becomes ->reply->not_found so need to make sure
    tests are covering that and fix it. consequence of this is having
    to bump the min version required of Mojolicious to v6.00
Commits on Jan 22, 2015
Commits on Jan 21, 2015
  1. resolve #1 make default post hook around_dispatch

    leejo committed Jan 21, 2015
    as an after_dispatch can trigger out of order and this can cause the
    nytprofcall script to panic, resulting in lack of a flame graph and
    possibly incomplete (or confused) profile output
  2. Merge pull request #3 from gmorten1/issue_1_JM

    leejo committed Jan 21, 2015
    move main ExampleApp.pm and controller to separate files
Commits on Jan 20, 2015
  1. test script for GH #1

    leejo committed Jan 20, 2015
    run:
    
    	perl -Ilib ~/bin/morbo t/example_app.pl
    
    visit:
    
    	http://localhost:3000/t1  (then t2, t3, t4)
    
    visit:
    
    	http://localhost:3000/nytprof
    
    click on each and see if you:
    
    	a) get the flame graph in the profile (i do)
    	b) see any errors in the call to nytprofhtml (i don't)
Commits on Oct 16, 2014
  1. tweak ordering of default paths for nytprofhtml

    leejo committed Oct 16, 2014
    cpantesters is showing failures of the form:
    
      Profile data created by incompatible perl config (NV size 16 but ours is 8)
      at /usr/lib/x86_64-linux-gnu/perl5/5.20/Devel/NYTProf/Data.pm line 87.
    
    if you look at the path it is actually using a different path to the
    perl running the tests:
    
      /home/sand/src/perl/repoperls/installed-perls/perl/v5.18.4/127e/bin/perl
    
    so calling File::Which::which is giving us the *system* perl's
    nytprofhtml path. switch the ordering of defaults to first use the
    nytprofhtml that will be in the same path as the perl running the
    tests/code so we don't end up getting a potentially incompatible
    system perl
    
    bump version to 0.12
Commits on Oct 14, 2014
  1. remove blank line between =for html and next line

    leejo committed Oct 14, 2014
    otherwise breaks rendering of links
  2. v0.10 adding missing files to MANIFEST

    leejo committed Oct 14, 2014
    caused some test failures on travis against different versions of
    perl so should release this
  3. add coveralls to .travis.yml and link to badges

    leejo committed Oct 14, 2014
    add couple of files to MANIFEST that should hopefully make build
    pass on travis
Commits on Sep 10, 2014
  1. knock number of test jobs down to 1 in .travis.yml

    leejo committed Sep 10, 2014
    parallel testing causing some interference and test failures
Commits on Sep 6, 2014
Commits on Sep 4, 2014
  1. remove 5.8 from .travis.yml

    leejo committed Sep 4, 2014
  2. check compatible with latest version of Mojolicious (5.37)

    leejo committed Sep 4, 2014
    needs a tweak in routing redirect post profile generation. add test
    for Changes file, and fix it. cleanup MANIFEST. bump version to 0.08
Commits on Jul 29, 2014
  1. disable emails from travis

    leejo committed Jul 29, 2014
Commits on Jul 21, 2014
  1. README -> README.md

    leejo committed Jul 21, 2014
    using pod2markdown then adding link to travis build status
Commits on Jul 18, 2014
  1. BAIL_OUT if nytprofhtml can't be found

    leejo committed Jul 18, 2014
    add .travis.yml for CI against all [most] perls
Commits on Apr 25, 2014
  1. fix typo in perldoc

    leejo committed Apr 25, 2014
  2. missing file from MANIFEST

    leejo committed Apr 25, 2014