New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Typescript typing #50

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@micmro

micmro commented Apr 3, 2017

Thanks for writing this useful validators.

To make them even more useful when working with TypeScript or VS Code it would be great to additionally have type completion.
I have added a Type Definition file to get autocompletion and TypeChecks (and some Tests for it). It would be great if you could release them with the npm package.

screen shot 2017-04-03 at 10 43 18 pm

@micmro

This comment has been minimized.

micmro commented Apr 12, 2017

Hi @HurricaneJames, do you have any concerns or feedback with this?

@hamishhossack

Looks good to me 👍 Let's go.

@technicallyfeasible

Don't see anything wrong with this, should be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment