Skip to content

Add containerPort option to avoid using HTTPS port 443 for plain HTTP #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2021

Conversation

denis-ryzhkov
Copy link
Contributor

I was confused by HTTPS port 443 being used also as containerPort with plain HTTP traffic.

Seeing that health checks fail trying to access my docker image via port 443, while it expects port 8080, lead me to adding containerPort option to this plugin copy to clearly have port: 443 for HTTPS ALB listener and containerPort: 8080 for HTTP in TargetGroup and ECS container, to see clear SSL unwrapping happening at ALB.

Later I discovered the true reason of health check failure was the issue #2 I reported, so please fix that issue first.

But to avoid further confusion of other users of this plugin regarding HTTPS port != HTTP containerPort, please also review and merge this PR

@gwdp
Copy link
Contributor

gwdp commented Oct 28, 2021

Since we are talking about the port used between the ALB and the container I always had the assumption you could map out the container port to be 443 independently of the protocol, but you are totally right, there are use cases where we could want to route to a different port. Building and bumping npm later tonight.

Really thanks for the contribution, appreciate it :)

@gwdp gwdp merged commit 0a94d7f into Hybridless:master Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants