Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SetGameCommand): do not send url if not streaming #41

Merged
merged 1 commit into from May 14, 2019

Conversation

Projects
None yet
2 participants
@SpaceEEC
Copy link
Member

commented May 14, 2019

This PR fixes two bugs in the SetGameCommand:

  • Sending an empty string when 'PLAYING'
    Apparently this silently fails on Discord's end
  • Sending an invalid twitch url when 'STREAMING'
    This is a leftover from the broadcast eval string -> function migration a while back.
fix(SetGameCommand): do not send url if not streaming
Also send proper url if streaming

@SpaceEEC SpaceEEC added the fix label May 14, 2019

@wizardlink wizardlink merged commit 4c3a11e into beta May 14, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@SpaceEEC SpaceEEC deleted the fix/setgame_parameters branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.