Compiled Bug Fixes from the October Muse Bug Bash #287
Conversation
Cahill Muse Fixes
Fix some bugs on live stream
Bugfixes for Hygieia Core
This pull request fixes 8 alerts when merging a464bae into f9ee7ff - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update your branch and increment the version in pom.xml to 3.11.1
This pull request fixes 8 alerts when merging 8bb32f2 into 1469a2b - view on LGTM.com fixed alerts:
|
This pull request fixes 8 alerts when merging 6703bd9 into 0c54deb - view on LGTM.com fixed alerts:
|
@nescohen let me look into this in couple of days |
@rvema have you gotten a chance to look at this yet? No worries if not. |
On it, found branch needs to be updated. Can you do so and increment the version accordingly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions, Please address the review comments.
src/main/java/com/capitalone/dashboard/collector/CollectorTaskWithGenericItem.java
Outdated
Show resolved
Hide resolved
@@ -303,10 +303,6 @@ public void setPolicyAlert(List<PolicyScanMetric> policyAlert) { | |||
this.policyAlert = policyAlert; | |||
} | |||
|
|||
private String getComponentPlusDisposition (String component, LibraryPolicyThreatDisposition disposition) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i am assuming this is unused private method, please confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is unused unless through some complex reflection. I did a string search as well through the repository. However this method Kinda looks like it is part of a group. I might not have removed it if I were making the changes (I did not personally do this one), so I would be happy to leave it in (revert) if you would prefer that.
@@ -154,13 +154,4 @@ private void processBuild(Build build) { | |||
} | |||
return dashboards; | |||
} | |||
|
|||
|
|||
private CollectorItem getCollectorItem(ObjectId id) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming these are unused private methods please confirm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above ^
This pull request fixes 8 alerts when merging 4fc1417 into 6002cad - view on LGTM.com fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This merge request is a collection of crowd-sourced bugfixes from the Muse Bug Bash ran in October. The Muse Bug Bash was first run at ApacheCon 2020 and it was a great way to introduce open source contribution to developers who otherwise might not be interested. This latest round of the Muse Bug Bash focused hygieia core and concord open source repositories. I am pleased to have compiled all of the our fixes into this MR and and I am hoping to upstream them to you.
The fixes focus on some commonly occurring bugs in java projects such as: