Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Compiled Bug Fixes from the October Muse Bug Bash #287

Merged
merged 25 commits into from Jan 5, 2021
Merged

Compiled Bug Fixes from the October Muse Bug Bash #287

merged 25 commits into from Jan 5, 2021

Conversation

nescohen
Copy link
Contributor

This merge request is a collection of crowd-sourced bugfixes from the Muse Bug Bash ran in October. The Muse Bug Bash was first run at ApacheCon 2020 and it was a great way to introduce open source contribution to developers who otherwise might not be interested. This latest round of the Muse Bug Bash focused hygieia core and concord open source repositories. I am pleased to have compiled all of the our fixes into this MR and and I am hoping to upstream them to you.

The fixes focus on some commonly occurring bugs in java projects such as:

Nes Cohen and others added 19 commits October 14, 2020 16:24
fix possible null pointer dereference
ac1335d
add missing overrides
108c210
fix possibly mutable enum
5a5415f
fix two inefficient keyset iterator
06756c9
@nswami-muse
Security Bug fixed changed encryption from DES to AES
234b7dc
@nswami-muse
EqualsGetClass Errors
c13c110
@nswami-muse
Stringbuffer Bug fix
d65446f
@dacahill7
Overrides and fixing getClass to instanceof
b0e5902
@dacahill7
Fix parenthesis
030e18d
@nswami-muse
Fixes
9e0bf03
@dacahill7
Fix variables
04226d3
@dacahill7
fix spacing
362d33f
@dacahill7
Change getClass to instanceof
d55f7a0
Merge pull request #3 from dacahill7/fix/Cahill
b925ba7 
Cahill Muse Fixes
Merge branch 'master' into does-livestream-fixes
c2841a8
Merge pull request #1 from nescohen/does-livestream-fixes
e8013c8 
Fix some bugs on live stream
Merge branch 'master' into bugfix/v1
faf32a2
Merge remote-tracking branch 'upstream/master' into bugfix/v1
cf0e625
Merge pull request #4 from Muse-Dev/bugfix/v1
a464bae 
Bugfixes for Hygieia Core
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Nov 20, 2020
@CLAassistant
Copy link

CLAassistant commented Nov 20, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@lgtm-com
Copy link

lgtm-com bot commented Nov 20, 2020

This pull request fixes 8 alerts when merging a464bae into f9ee7ff - view on LGTM.com

fixed alerts:

  • 8 for Use of a broken or risky cryptographic algorithm

rvema
rvema suggested changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@rvema rvema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your branch and increment the version in pom.xml to 3.11.1

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Nov 30, 2020
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Nov 30, 2020
@lgtm-com
Copy link

lgtm-com bot commented Nov 30, 2020

This pull request fixes 8 alerts when merging 8bb32f2 into 1469a2b - view on LGTM.com

fixed alerts:

  • 8 for Use of a broken or risky cryptographic algorithm

@nescohen nescohen requested a review from rvema December 3, 2020 19:35
@lgtm-com
Copy link

lgtm-com bot commented Dec 3, 2020

This pull request fixes 8 alerts when merging 6703bd9 into 0c54deb - view on LGTM.com

fixed alerts:

  • 8 for Use of a broken or risky cryptographic algorithm

@rvema
Copy link
Contributor

rvema commented Dec 4, 2020

@nescohen let me look into this in couple of days

@rvema rvema self-assigned this Dec 4, 2020
@nescohen
Copy link
Contributor Author

@rvema have you gotten a chance to look at this yet? No worries if not.
I'm happy to make any fixes if you need.

@rvema
Copy link
Contributor

rvema commented Dec 12, 2020

On it, found branch needs to be updated. Can you do so and increment the version accordingly

rvema
rvema suggested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@rvema rvema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions, Please address the review comments.

src/main/java/com/capitalone/dashboard/collector/CollectorTaskWithGenericItem.java Outdated Show resolved Hide resolved
src/main/java/com/capitalone/dashboard/model/LibraryPolicyResult.java
@@ -303,10 +303,6 @@ public void setPolicyAlert(List<PolicyScanMetric> policyAlert) {
this.policyAlert = policyAlert;
}

private String getComponentPlusDisposition (String component, LibraryPolicyThreatDisposition disposition) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am assuming this is unused private method, please confirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is unused unless through some complex reflection. I did a string search as well through the repository. However this method Kinda looks like it is part of a group. I might not have removed it if I were making the changes (I did not personally do this one), so I would be happy to leave it in (revert) if you would prefer that.

src/main/java/com/capitalone/dashboard/event/BuildEventListener.java
@@ -154,13 +154,4 @@ private void processBuild(Build build) {
}
return dashboards;
}


private CollectorItem getCollectorItem(ObjectId id) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming these are unused private methods please confirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above ^

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Dec 14, 2020
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Dec 15, 2020
@nescohen nescohen requested a review from rvema December 15, 2020 22:04
@lgtm-com
Copy link

lgtm-com bot commented Dec 15, 2020

This pull request fixes 8 alerts when merging 4fc1417 into 6002cad - view on LGTM.com

fixed alerts:

  • 8 for Use of a broken or risky cryptographic algorithm

rvema
rvema approved these changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@rvema rvema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rvema rvema merged commit 28965ab into hygieia:master Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rvema rvema rvema approved these changes

Assignees

@rvema rvema

Labels
🔍 Ready for Review Pull Request is not reviewed yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nescohen @CLAassistant @rvema @nswami-muse @dacahill7