Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not linkify links with russian simbols #100

Closed
arsenichev opened this issue Dec 27, 2015 · 6 comments
Closed

Not linkify links with russian simbols #100

arsenichev opened this issue Dec 27, 2015 · 6 comments

Comments

@arsenichev
Copy link

@arsenichev arsenichev commented Dec 27, 2015

If linkify string "Test string and url to wiki https://ru.wikipedia.org/wiki/Список_птиц,_занесённых_в_Красную_книгу_России" lib dont find this link.

@cawa-93
Copy link
Contributor

@cawa-93 cawa-93 commented Dec 27, 2015

Confirm. Returns a string

Test string and url to wiki <a href="https://ru.wikipedia.org/wiki/" class="linkified" target="_blank">https://ru.wikipedia.org/wiki/</a>Список_птиц,_занесённых_в_Красную_книгу_России

Using linkifyjs#2.0.0-beta.7

@arsenichev
Copy link
Author

@arsenichev arsenichev commented Dec 27, 2015

@denya-vs
Copy link

@denya-vs denya-vs commented May 17, 2016

Hi, what about this issue? This plugin is awesome, but I can not use it for cyrillic domain or urls.
If you do not has time, can you tell me how to fix it?

@fcarreiro
Copy link

@fcarreiro fcarreiro commented Jul 7, 2016

Interesting, the problem also happens with other non-ascii symbols, when they are in the last position:
screen shot 2016-07-08 at 00 33 29

@fcarreiro
Copy link

@fcarreiro fcarreiro commented Jul 7, 2016

@nfrasser what is the general UTF support of this library? I couldn't find it :)

nfrasser added a commit that referenced this issue Jul 17, 2016
Now that quotes and parens/brackets get special treatment, there's no longer a
need to leave off trailing non-standard URL symbols.

Fixes #108
Fixes #143

Partially addresses #100
nfrasser added a commit that referenced this issue Jul 17, 2016
Now that quotes and parens/brackets get special treatment, there's no longer a
need to leave off trailing non-standard URL symbols.

Fixes #108
Fixes #143

Partially addresses #100
nfrasser added a commit that referenced this issue Jul 17, 2016
Now that quotes and parens/brackets get special treatment, there's no longer a
need to leave off trailing non-standard URL symbols.

Fixes #108
Fixes #143

Partially addresses #100
nfrasser added a commit that referenced this issue Jul 17, 2016
* Scanner enhancements
  * Allow states to have a default state transition
  * Move away from regular expression state transitions
* Parse trailing symbols in URLs more greedily
  * Now that quotes and parens/brackets get special treatment, there's no longer a need to leave off trailing non-standard URL symbols.

Fixes #108
Fixes #143

Partially addresses #100
@nfrasser
Copy link
Collaborator

@nfrasser nfrasser commented Jul 17, 2016

@fcarreiro the non-ASCII symbol issue was a long-running bug. It was just fixed in the latest release.

The sample URLs included here should all be working (Russian symbols are now supported in the query string), but there are still issues with international domain names - see #92. I'm closing this one off in favour of that.

@nfrasser nfrasser closed this Jul 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants