Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix our other version bounds in setup.py #1383

Closed
alexwlchan opened this issue Jul 4, 2018 · 1 comment · Fixed by #1530
Closed

Fix our other version bounds in setup.py #1383

alexwlchan opened this issue Jul 4, 2018 · 1 comment · Fixed by #1530
Labels
enhancement it's not broken, but we want it to be better

Comments

@alexwlchan
Copy link
Contributor

Pulling out @Zac-HD's comment from #1379:

This looks good to me, but it occurs to me that we should probably add version specifiers to pytz and python-dateutil to make sure the problem doesn't arise for them. (maybe in a future PR)

My best suggestion for determining the exact bound is to write a git-bisect-like script to try them against our datetime test directory and just brute-force it 😕
@alexwlchan alexwlchan mentioned this issue Jul 4, 2018
Merged
@Zac-HD Zac-HD added enhancement it's not broken, but we want it to be better good first issue labels Jul 4, 2018
@00willo 00willo mentioned this issue Aug 27, 2018
Closed
@00willo
Copy link
Contributor

00willo commented Aug 27, 2018

Working on for the sprints.

@00willo 00willo mentioned this issue Aug 27, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement it's not broken, but we want it to be better
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve setup.py 00willo/hypothesis
3 participants
@alexwlchan @00willo @Zac-HD