Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on OSX for v3.69.3 and v3.69.4 #1532

Closed
jochym opened this issue Aug 27, 2018 · 11 comments
Closed

Tests fail on OSX for v3.69.3 and v3.69.4 #1532

jochym opened this issue Aug 27, 2018 · 11 comments

Comments

@jochym
Copy link

jochym commented Aug 27, 2018

See runs on conda-forge builder:
https://travis-ci.org/conda-forge/hypothesis-feedstock/builds/421092094

@Zac-HD
Copy link
Member

Zac-HD commented Aug 27, 2018

Upstream bug in Pytest 3.7.3: pytest-dev/pytest#3888

@Zac-HD Zac-HD closed this as completed Aug 27, 2018
@jochym
Copy link
Author

jochym commented Aug 28, 2018

Shall we pack the release anyway? Will it fix itself after fixing pytest?

@Zac-HD
Copy link
Member

Zac-HD commented Aug 28, 2018

You just need to force pytest to away from 3.7.3 and it will pass, this isn't a hypothesis problem.

@jochym
Copy link
Author

jochym commented Aug 28, 2018

Ok. Thanks

@jochym
Copy link
Author

jochym commented Aug 28, 2018

Should it be >= 3.7.3 or above 3.7.3?

@Zac-HD
Copy link
Member

Zac-HD commented Aug 28, 2018

Gah, had a typo on my phone sorry. The latest version of pytest is 3.7.3 and that's the buggy version.

A version spec like pytest>=3.1,!=3.7.3 should work and pick up a fix automatically, or you could pin to pytest==3.7.2.

@jochym
Copy link
Author

jochym commented Aug 28, 2018

Thanks!

@jochym
Copy link
Author

jochym commented Aug 28, 2018

It seems there is still some problem with this release. After pinning pytest to !=3.7.2 tests on all platforms now fail. And the failure is different. Would you care to take a look @Zac-HD ?
conda-forge/hypothesis-feedstock#130

@Zac-HD
Copy link
Member

Zac-HD commented Aug 28, 2018

I doubt I'll have time to fix it tonight, but it looks like the new test from #1524 is failing. Can you open a new issue for that?

@jochym
Copy link
Author

jochym commented Aug 28, 2018 via email

@jochym
Copy link
Author

jochym commented Aug 29, 2018

Done (#1543)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants