Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings in Python 3.8 (CPython master) #1576

Closed
tirkarthi opened this issue Sep 14, 2018 · 2 comments · Fixed by #1578
Closed

Warnings in Python 3.8 (CPython master) #1576

tirkarthi opened this issue Sep 14, 2018 · 2 comments · Fixed by #1578
Labels
bug something is clearly wrong here

Comments

@tirkarthi
Copy link
Contributor

Trying to install hypothesis shows the following warning in CPython master. I searched for the related warning and master branch but I couldn't find any issue so I am reporting it here.

/home/karthi/pandas-venv/lib/python3.8/site-packages/hypothesis/strategies.py:32: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working
from collections import Sequence

Thanks

@Zac-HD Zac-HD added bug something is clearly wrong here good first issue labels Sep 14, 2018
@Zac-HD
Copy link
Member

Zac-HD commented Sep 14, 2018

Thanks for reporting this! Would you like to open a PR and fix it?

The patch will consist of deleting that import, prepending abc to the names imported from hypothesis.internal.compat (line 42), and replacing the only runtime use of Sequence with abc.Sequence (line 973). Then add a RELEASE.rst for a patch release (copy from one of my open PRs, and see the changelog for message style), add your name to the list of authors in CONTRIBUTING.rst, and we're done!

@tirkarthi
Copy link
Contributor Author

Sure, thanks for the information. I will raise a PR by the weekend.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is clearly wrong here
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants