Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
I was playing around with stateful testing earlier today, and messed up a function call. Here's the problem: this caused an internal error instead of a validation error with a nice message!
Then add tests to
You're welcome to check for other cases of missing validation, and we'd love fixes for them, but we would encourage that to happen in follow-up PRs. Better to merge small changes regularly than have them build up and get stuck!
How do we know what types to compare against? Do we need to somehow extract the usage of kwargs from f?
In both cases (Settings, RuleBasedStateMachine), the check_type is against a locally created object. This is not the case with kwargs.
I couldn't find this in other PRs, do you have an example?
Thanks in advance
Hey @NNRepos - I hope you're enjoying Hypothesis
Here's a good example of a pull request including contributors entry, release file, change, and tests!
I'm also new to hypothesis and would like to help contribute if this issue is still open. I was hoping you could clarify something for me.
It looks like both
Hey @benjpalmer - welcome! We'll reserve this issue for you for a week; after that anyone else can open a PR
The validation for
for k, v in kwargs.items(): check_type(SearchStrategy, v, k)
plus tests, a changelog, and your name in the authors list