Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up defines_strategy code in core.py #2516

Closed
DRMacIver opened this issue Jul 27, 2020 · 1 comment · Fixed by #2597
Closed

Tidy up defines_strategy code in core.py #2516

DRMacIver opened this issue Jul 27, 2020 · 1 comment · Fixed by #2597
Labels
internals Stuff that only Hypothesis devs should ever see

Comments

@DRMacIver
Copy link
Member

A small clean up ticket for whomever is in the mood (which might be future me). In reviewing #2515 I noticed that the defines_strategy code is a little bit of a mess.

I think we should inline all of the following definitions to their use site:

defines_strategy = base_defines_strategy(False)
defines_strategy_with_reusable_values = base_defines_strategy(True)
defines_strategy_without_laziness = base_defines_strategy(False, try_non_lazy=True)

We should also make force_reusable_values a keyword only argument defaulting to False.

None of this is public API, so no deprecation is needed for anything, it's just a light tidy up.
@DRMacIver DRMacIver added the internals Stuff that only Hypothesis devs should ever see label Jul 27, 2020
@Zac-HD Zac-HD mentioned this issue Sep 5, 2020
Closed
@darkpaw
Copy link

darkpaw commented Sep 6, 2020

looking at this for pycon-au 2020 sprints

darkpaw pushed a commit to darkpaw/hypothesis that referenced this issue Sep 6, 2020
@gsnsw-felixs
tidy defines_strategy decorators HypothesisWorks#2516
f259835
@darkpaw darkpaw mentioned this issue Sep 6, 2020
Merged
darkpaw pushed a commit to darkpaw/hypothesis that referenced this issue Sep 6, 2020
@gsnsw-felixs
tidy defines_strategy decorators HypothesisWorks#2516
1f35450
Zac-HD pushed a commit to darkpaw/hypothesis that referenced this issue Sep 6, 2020
@gsnsw-felixs @Zac-HD
tidy defines_strategy decorators HypothesisWorks#2516
1bf75ed
Zac-HD added a commit that referenced this issue Sep 6, 2020
@Zac-HD
Merge pull request #2597 from darkpaw/tidy_defines_strategy
a65aff6 
Tidy defines_strategy decorators (#2516)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internals Stuff that only Hypothesis devs should ever see
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tidy defines_strategy decorators (#2516) darkpaw/hypothesis
2 participants
@DRMacIver @darkpaw