Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test st.from_type() on builtin generics from Python 3.9 #2629

Closed
Zac-HD opened this issue Sep 27, 2020 · 1 comment · Fixed by #2653
Closed

Test st.from_type() on builtin generics from Python 3.9 #2629

Zac-HD opened this issue Sep 27, 2020 · 1 comment · Fixed by #2653
Assignees
Labels
enhancement it's not broken, but we want it to be better tests/build/CI about testing or deployment *of* Hypothesis

Comments

@Zac-HD
Copy link
Member

Zac-HD commented Sep 27, 2020

Python 3.9 is coming out soon! Happily, we're already running it in our CI - so anything that worked before still works on the new Python. There are however also new features, like PEP 585 (type annotations using builtins as generics).

As Guido highlights, we should also check that everything works with from __future__ import annotations - that's not new in 3.9 but will become the default behaviour in 3.10!

I don't think we actually need any new logic to handle this, but we should really add some py39-only tests to make sure it keeps working 😁

@Zac-HD Zac-HD added the tests/build/CI about testing or deployment *of* Hypothesis label Sep 27, 2020
@Zac-HD
Copy link
Member Author

Zac-HD commented Oct 29, 2020

WIP at master...Zac-HD:pep585-annotations and it turns out that we do need some new logic after all. Ah well.

@Zac-HD Zac-HD self-assigned this Oct 29, 2020
@Zac-HD Zac-HD added the enhancement it's not broken, but we want it to be better label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement it's not broken, but we want it to be better tests/build/CI about testing or deployment *of* Hypothesis
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant