Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python autoformatting stack #2780

Closed
Zac-HD opened this issue Jan 26, 2021 · 0 comments · Fixed by #2792
Closed

Update Python autoformatting stack #2780

Zac-HD opened this issue Jan 26, 2021 · 0 comments · Fixed by #2792
Assignees
Labels
tests/build/CI about testing or deployment *of* Hypothesis

Comments

@Zac-HD
Copy link
Member

Zac-HD commented Jan 26, 2021

The autoformatting stack we use for Python is pretty good, but IMO shed is even better. I might be biased because I wrote it, but then again I wrote it specifically to be a more-comprehensive and easier-to-use version of Hypothesis' autoformatter stack.

Now that Hypothesis has dropped Python 3.5 support and we've migrated our CI, it makes sense to change over. I expect this to be a single PR, in four commits:

  1. Run pyupgrade without the --keep-percent-format flag
  2. Manually fix any issues that this created or %-formatting that it couldn't autofix
  3. Fix any console blocks which don't start with >>> (git grep -A 3 '.. code-block:: pycon' finds them)
  4. Convert over to run shed --refactor
  5. Manually fix any issues or ugly formatting this created

Aiming to sort this out in early Feb after Zac-HD/shed#11 🙂

@Zac-HD Zac-HD added the tests/build/CI about testing or deployment *of* Hypothesis label Jan 26, 2021
@Zac-HD Zac-HD self-assigned this Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests/build/CI about testing or deployment *of* Hypothesis
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant