Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The URL strategy does not include query strings nor fragments #2908

Closed
P403n1x87 opened this issue Mar 15, 2021 · 3 comments · Fixed by #2963
Closed

The URL strategy does not include query strings nor fragments #2908

P403n1x87 opened this issue Mar 15, 2021 · 3 comments · Fixed by #2963
Labels
enhancement it's not broken, but we want it to be better

Comments

@P403n1x87
Copy link

The RFC 3986 describes the query and fragment component of URIs. The URL provisional strategy doesn't seem to implement these components. It would be good to have these added as well for more comprehensive testing.

@Zac-HD Zac-HD added the enhancement it's not broken, but we want it to be better label Mar 15, 2021
@Zac-HD
Copy link
Member

Zac-HD commented Mar 15, 2021

That's the main reason it's provisional! We'd be happy to accept a PR adding fragments and/or query strings.

@paxcodes
Copy link
Contributor

Should we keep this issue open since query strings still need to be generated?

@Zac-HD
Copy link
Member

Zac-HD commented May 18, 2021

I'm happy to accept a PR adding query strings if you (or anyone else) wants to write one, but with the mentored sprints over I'm also happy to leave the provisional strategies as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement it's not broken, but we want it to be better
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants