Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn the return_value and not_a_test_method health checks into strict errors #3568

Closed
Zac-HD opened this issue Feb 4, 2023 · 0 comments · Fixed by #3610
Closed

Turn the return_value and not_a_test_method health checks into strict errors #3568

Zac-HD opened this issue Feb 4, 2023 · 0 comments · Fixed by #3610
Labels
docs documentation could *always* be better legibility make errors helpful and Hypothesis grokable

Comments

@Zac-HD
Copy link
Member

Zac-HD commented Feb 4, 2023

This is pretty much just code cleanup: unlike the other healthchecks which are basically performance checks, I'm pretty sure there's never a situation where disabling these allows you to do something useful. I think we should therefore:

  • Turn the return_value and not_a_test_method health checks into strict errors.
  • Define HealthCheck.__iter__() and .all() such that they're omitted from that
  • Use note_deprecation() if the attributes are accessed on HealthCheck
  • Merge the healthcheck docs into the main settings docs
  • [me, after we merge] add a redirect on readthedocs to avoid 404'ing links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs documentation could *always* be better legibility make errors helpful and Hypothesis grokable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant