Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve our internal coverage tests #4003

Closed
tybug opened this issue May 23, 2024 · 3 comments · Fixed by #4011 or #4019
Closed

Improve our internal coverage tests #4003

tybug opened this issue May 23, 2024 · 3 comments · Fixed by #4011 or #4019
Labels
tests/build/CI about testing or deployment *of* Hypothesis

Comments

@tybug
Copy link
Member

tybug commented May 23, 2024

Our ./build.sh check-coverage job has a misconfiguration where it only checks that hypothesis.internal.conjecture is fully covered:

--cov=hypothesis.internal.conjecture --cov-config=.coveragerc \

This should be --cov=hypothesis, to ensure we have coverage over the entire codebase.

And it turns out we don't! We should add coverage tests to get to 100% coverage here, then fix the --cov argument.

@tybug tybug added the tests/build/CI about testing or deployment *of* Hypothesis label May 23, 2024
@jobh
Copy link
Contributor

jobh commented Jun 14, 2024

It looks like the problem is of recent date, b688f39.

It's best to fix it quickly so the coverage gap doesn't grow too overwhelming. I can probably make a start over the weekend.

Good catch @tybug!

@tybug
Copy link
Member Author

tybug commented Jun 14, 2024

I can’t take too much credit, this was discovered independently at pycon 😄. Glad to hear this isn't years old, at least.

@jobh
Copy link
Contributor

jobh commented Jun 24, 2024

Reopened to track the three remaining coverage holes

  • hypothesis/core.py:1109
  • hypothesis/internal/entropy.py:130
  • hypothesis/stateful.py:391

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests/build/CI about testing or deployment *of* Hypothesis
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants