-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbosity setting not always respected #944
Comments
|
Nope, |
|
Hmm. This doesn't happen under Python 2.7, at least on Travis. Suggests that investigating version differences is likely to be important. |
|
I'm not certain if this is related but under Python 3.6.1 I have pytest test functions that will dynamically skip certain tests. When a test is skipped the seed message is displayed even when verbosity is set to quiet. This isn't the behavior I expected. If I can help with additional details please let me know. |
|
Hmm, @rbdixon, an example of that seems like it might be pretty useful if you can provide one. |
|
Found the bug; the relevant part of |
This is a fairly subtle bug I found while working on #931.
After fixing the Django tests to use Dajngo-2.0 idioms, I ran into a weird issue with passing tests printing an
@seednote even when they passed.This happens because the inner test throws an error in example generation, therefore fails and prints a note, then passes because that's what the outer test wanted to see. The problem is that adding
@setting(verbosity=Verbosity.quiet)on the inner test should disable this message, but currently doesn't.My initial fix is here - note that I had to use a
with settings(...)because simply adding it to the test settings didn't work.The text was updated successfully, but these errors were encountered: