regex strategy ignoring re.VERBOSE

[AlvarBer]

I have a regex expression that uses re.VERBOSE flag for improved readability, and when it is used as a strategy it throws a FailedHealthCheck, however the same regex without the flag and compressed on a single line works fine.

I suspect this is due to from_regex strategy ignoring the re.VERBOSE flag and trying to match the full regex including whitespace and newlines, a quick search in searchstrategy/regex.py shows that the VERBOSE flag is not checked anywhere.

[Zac-HD]

Thanks for the report - your diagnosis is correct, this is definitely a bug, and we should fix it. Notes on that:

• parse things with sre_parse.parse(regex.pattern, flags=regex.flags)
• _strategy should take a boolean is_text, not the pattern itself
• add some tests with re.VERBOSE, including patterns where this changes the match
• check whether there are other neglected flags