Limit generated emails to 254 characters #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
reviewed
Feb 14, 2019
There was a problem hiding this comment.
Thanks for spotting this! We'll just need a RELEASE.rst file (see other PRs for examples), with content like the following:
RELEASE_TYPE: patch
This patch fixes an off-by-one error in the maximum length of :func:`~hypothesis.strategies.emails`.
Thanks to Krzysztof Jurewicz for :pull:`1812`.
RFC 5321 states that “The maximum total length of a reverse-path or forward-path is 256 octets (including the punctuation and element separators).”, hence, as path has to contain two angle brackets, it limits email length to 254 characters.
KrzysiekJ
force-pushed
the
email-length
branch
from
7443324
to
eabf710
Compare
|
Ok, added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 5321 states that “The maximum total length of a reverse-path or forward-path is 256 octets (including the punctuation and element separators).”, hence, as path has to contain two angle brackets, it limits email length to 254 characters.
See https://stackoverflow.com/a/574698 for more details.