Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around weird behavior of np.dtype #1963

Merged
merged 1 commit into from May 7, 2019

Conversation

@Zac-HD
Copy link
Member

Zac-HD commented May 7, 2019

Fixes #1798. Paraphrasing my comment there: it's triggered by a weird behaviour of np.dtype that can be rarely found by npst.array_dtypes(), where:

np.dtype([("f1", int), ("", int)]) fails, as does anything where the name "f{index}" exists elsewhere but the name at the index is "" (e.g. dtype([('', int), ('f0', int)])) - the empty name defaults to the f{index} name even if it exists elsewhere, but obviously the unique_by doesn't catch that. We can ensuring that all field names are non-empty is a decent workaround until I can talk it over with upstream.

@Zac-HD Zac-HD added the flaky-tests label May 7, 2019
@Zac-HD Zac-HD force-pushed the Zac-HD:fix-dtype-flakiness branch from c61fe20 to 68e396d May 7, 2019
@rsokl
rsokl approved these changes May 7, 2019
Copy link
Contributor

rsokl left a comment

Looks good to me

@Zac-HD Zac-HD merged commit 7eec4da into HypothesisWorks:master May 7, 2019
4 checks passed
4 checks passed
HypothesisWorks.hypothesis #20190507.4 succeeded
Details
ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Zac-HD Zac-HD deleted the Zac-HD:fix-dtype-flakiness branch May 7, 2019
@Zac-HD Zac-HD mentioned this pull request Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.