Work around weird behavior of np.dtype #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
force-pushed
the
fix-dtype-flakiness
branch
from
c61fe20
to
68e396d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1798. Paraphrasing my comment there: it's triggered by a weird behaviour of
np.dtypethat can be rarely found bynpst.array_dtypes(), where:np.dtype([("f1", int), ("", int)])fails, as does anything where the name"f{index}"exists elsewhere but the name at the index is""(e.g.dtype([('', int), ('f0', int)])) - the empty name defaults to thef{index}name even if it exists elsewhere, but obviously theunique_bydoesn't catch that. We can ensuring that all field names are non-empty is a decent workaround until I can talk it over with upstream.