Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes xrange registered strategy #1974

Merged
merged 3 commits into from May 8, 2019

Conversation

Projects
None yet
2 participants
@rsokl
Copy link
Contributor

commented May 8, 2019

Closes #1972

@rsokl

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@Zac-HD, we lost coverage here:

if math.isnan(value) or (math.isinf(value) and value > 0):
return value

has this been an issue before?

@Zac-HD

This comment has been minimized.

Copy link
Member

commented May 8, 2019

FYI: list of keywords that close issues.

I've just pushed an extra test for the next_up/next_down utilities in these cases.

@Zac-HD

Zac-HD approved these changes May 8, 2019

@Zac-HD Zac-HD merged commit 883f4b4 into master May 8, 2019

@Zac-HD Zac-HD deleted the xrange branch May 8, 2019

@rsokl

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.