Updae secure signals client server integrations fix #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Safety net: If token exists but Secure Signals haven't loaded yet, reload the page | ||
| if (token && !secureSignalsStorage) { | ||
| console.log("Token exists but Secure Signals not loaded yet, reloading page..."); | ||
| location.reload(); |
Contributor
Author
There was a problem hiding this comment.
Added just in case secure signals doesnt load properly with delay
Contributor
Author
There was a problem hiding this comment.
Also added condition to not reload on opt-out since the token wouldnt be generated
| } | ||
| <% } else if (isOptout) { %> | ||
| // Opt-out case - set identity to null | ||
| sdk.setIdentity(null); |
Contributor
There was a problem hiding this comment.
i don't think we should have to do this? the sdk should already take care of the optout identity
ashleysmithTTD
approved these changes
Nov 14, 2025
eiman-eltigani-ttd
deleted the
eee-UID2-6129-secure-signals-client-server-integrations-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes/key takeaways: