New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regional breakdowns like variables #106

Open
znicholls opened this Issue Oct 9, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@znicholls
Copy link
Collaborator

znicholls commented Oct 9, 2018

Something that occured to me during #88 and that might be a good future enhancement.

At the moment, if you have a dataframe with regions China, Japan, Germany, UK, Europe, Asia, World, it is not clear which regions are subsets of which other regions. Hence it's impossible to automate checking of regions over all combinations (i.e. countries should add to continents, continents to World).

If you had regions stored like variables (e.g. World|Europe|UK, World, World|Asia, World|Asia|China), then you could use the same aggregate checking logic etc. on regional breakdowns as variables.

@znicholls

This comment has been minimized.

Copy link
Collaborator

znicholls commented Oct 10, 2018

Thinking about this more, I'm not sure it's easy to cover all the possible cases. For example, if your file had regions 'world, northern hemisphere, Southern Hemisphere, r5asia, r5lam, r5maf, r5oecd, r5reg', the hierarchy wouldnt work as you do have to know how much of eg 'r5lam' goes in northern hemisphere and how much in Southern Hemisphere to do the checks. Hmm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment