New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Venezualian Bolivar #278

Merged
merged 2 commits into from Dec 7, 2018

Conversation

Projects
None yet
5 participants
@rolfkleef
Copy link
Contributor

rolfkleef commented Dec 6, 2018

As per https://www.currency-iso.org/dam/downloads/dl_currency_iso_amendment_168.pdf the new code VES replaces VEF per 2018-08-20

@rolfkleef

This comment has been minimized.

Copy link
Contributor Author

rolfkleef commented Dec 6, 2018

looks like my editor removed a few trailing spaces too

@samuele-mattiuzzo

This comment has been minimized.

Copy link
Contributor

samuele-mattiuzzo commented Dec 6, 2018

Waiting to merge till we get the changelog updated as well. Thanks @rolfkleef

<code>VEF</code>
<name>
<narrative>Bolivar</narrative>
</name>
</codelist-item>
<codelist-item>

This comment has been minimized.

@andylolz

andylolz Dec 6, 2018

Contributor

Looks good!

You could add status="active" activation-date="2018-08-20" here, as per the codelist management guidance:

All new codes added to codelist from the release of version 2.02 (December 2015) will feature status="active" and activation-date attributes in the underlying GitHub source code repositories.

This comment has been minimized.

@andylolz

andylolz Dec 7, 2018

Contributor

¯\_(ツ)_/¯

Show resolved Hide resolved xml/Currency.xml

amy-silcock added a commit to IATI/IATI-Guidance that referenced this pull request Dec 6, 2018

@samuele-mattiuzzo samuele-mattiuzzo merged commit 3a838f2 into IATI:master Dec 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment