New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 2.01 "3. Language neutral codelists" #25

Closed
Bjwebb opened this Issue Apr 9, 2014 · 9 comments

Comments

Projects
None yet
3 participants

@Bjwebb Bjwebb added this to the 2.01 Iteration 1 milestone Apr 9, 2014

@caprenter caprenter changed the title from Implement 2.01 "Language neutral code lists" to Implement 2.01 "3. Language neutral code lists" Apr 10, 2014

@Bjwebb

This comment has been minimized.

Contributor

Bjwebb commented Apr 10, 2014

I suggest that we simply rename the codes (ie. delete the old ones), instead of deprecating. http://support.iatistandard.org/entries/51310806-Delete-don-t-just-deprecate-codes-in-2-01

@Bjwebb

This comment has been minimized.

Contributor

Bjwebb commented Apr 15, 2014

Following discussion with @bill-anderson I'm going to implement this in Iteration 1 by replacing (deleting the old codes), instead of deprecating.

@caprenter

This comment has been minimized.

Contributor

caprenter commented May 29, 2014

See: http://support.iatistandard.org/entries/57958296-Version-2-01-Iteration-1-3-Language-Neutral-Code-lists
for an update.

Seems to me that there are 2 more changes to make:

  • "There was consensus at the Montreal TAG that "accountable" should be removed from the list" #33
  • "Change name to SectorVocabulary" (from Vocabulary)
@caprenter

This comment has been minimized.

Contributor

caprenter commented Jun 10, 2014

Removing 'accountable' from the OrgansiationRole list will mean renaming the codes on that list as set in this commit: 7c6b222 unless we want to start the codes at '2'.

@caprenter

This comment has been minimized.

Contributor

caprenter commented Jun 10, 2014

We want to follow the same conventions in the codelist xml as adopted in the activity schema for handling translations - this is yet to be agreed, but will mean altering the underlying codelist schema.

@bill-anderson

This comment has been minimized.

bill-anderson commented Jun 10, 2014

Agree we should renumber codes

@Bjwebb

This comment has been minimized.

Contributor

Bjwebb commented Jun 11, 2014

I've now removed Accountable and renumbered OrganisationRole and done the rename to SectorVocabulary

A couple of questions about SectorVocabulary:

  • I numbered this in the order the codes were previously on the list. This makes the DAC codes 3 and 4. Should these be renumbered to be 1 and 2 as they are the recommended options?
  • policy-marker/@vocabulary uses the SectorVocabulary codelist (in 1.04 it uses the Vocabulary codelist). Should it, or should there be a PolicyMarkerVocabulary codelist?
@caprenter

This comment has been minimized.

Contributor

caprenter commented Jun 11, 2014

Just a note that policy marker is under consideration on the Modifications forum as well:
http://support.iatistandard.org/entries/52320903-New-Policy-Markers-Significance-Codes

@Bjwebb

This comment has been minimized.

Contributor

Bjwebb commented Jun 16, 2014

@Bjwebb Bjwebb changed the title from Implement 2.01 "3. Language neutral code lists" to Implement 2.01 "3. Language neutral codelists" Jun 16, 2014

@Bjwebb Bjwebb closed this Jun 30, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment