New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement 2.01 "2. Additional mandatory conditions" #67

Closed
Bjwebb opened this Issue Apr 9, 2014 · 6 comments

Comments

Projects
None yet
3 participants
@Bjwebb
Contributor

Bjwebb commented Apr 9, 2014

http://support.iatistandard.org/entries/45539933-Thematic-content-agreed-by-IATI-Steering-Committee

http://support.iatistandard.org/entries/57417568-Version-2-01-Iteration-1-2-Additional-Mandatory-Conditions

The following proposals can be implemented in the schema:

  • change the definition of planned-disbursement to say, if it is a single date, then use the period start date. (discussion)
  • @iso-date should be required on period-start and period-end of budget and planned disbursement

The following can not currently be implemented using rulesets:

  • The budget element should be repeated for each year of the activity's duration
  • Each budget should cover a period no longer than 1 year

The rest will be implemented in the standard ruleset IATI/IATI-Rulesets#13

@Bjwebb Bjwebb added this to the 2.01 Iteration 1 milestone Apr 9, 2014

@Bjwebb Bjwebb changed the title from Implement 2.01 "Additional mandatory conditions" to Implement 2.01 "2. Additional mandatory conditions" Apr 15, 2014

@Bjwebb Bjwebb referenced this issue Apr 15, 2014

Closed

Implement 2.01 - Add new standard rules #13

16 of 16 tasks complete
@Bjwebb

This comment has been minimized.

Show comment
Hide comment
@Bjwebb

Bjwebb Jul 29, 2014

Contributor

During the work on the Iteration 2 proposal, we decided we should introduce ordering #138 in order to enforce mandatory elements in the schema. We therefore need to enumerate the new changes to the schema that are needed, and possibly also remove the relevant rules as redundant.

Contributor

Bjwebb commented Jul 29, 2014

During the work on the Iteration 2 proposal, we decided we should introduce ordering #138 in order to enforce mandatory elements in the schema. We therefore need to enumerate the new changes to the schema that are needed, and possibly also remove the relevant rules as redundant.

@Bjwebb

This comment has been minimized.

Show comment
Hide comment
@Bjwebb

Bjwebb Aug 18, 2014

Contributor
Contributor

Bjwebb commented Aug 18, 2014

@Bjwebb Bjwebb assigned caprenter and unassigned Bjwebb Aug 19, 2014

@Bjwebb Bjwebb assigned Bjwebb and unassigned caprenter Sep 4, 2014

@Bjwebb

This comment has been minimized.

Show comment
Hide comment
@Bjwebb

Bjwebb Sep 4, 2014

Contributor

Looking at the updated proposal http://support.iatistandard.org/entries/77285258-Version-2-01-Iteration-2-2-Additional-Mandatory-Conditions

These are implemented in the schema as part of David's occurs branch:

  • budget/period-start/@iso-date is MANDATORY and must be a valid ISO format
  • budget/period-end/@iso-date is MANDATORY and must be a valid ISO format
  • planned-disbursement/period-start/@iso-date is MANDATORY

Since these can be tested at the schema level, I will remove them from the standard ruleset - IATI/IATI-Rulesets#17

Can be tested with the current ruleset framework:

Can not be tested with the current ruleset framework:

  • The budget element should be repeated for each year of the activity's duration
  • Each budget should cover a period no longer than 1 year
Contributor

Bjwebb commented Sep 4, 2014

Looking at the updated proposal http://support.iatistandard.org/entries/77285258-Version-2-01-Iteration-2-2-Additional-Mandatory-Conditions

These are implemented in the schema as part of David's occurs branch:

  • budget/period-start/@iso-date is MANDATORY and must be a valid ISO format
  • budget/period-end/@iso-date is MANDATORY and must be a valid ISO format
  • planned-disbursement/period-start/@iso-date is MANDATORY

Since these can be tested at the schema level, I will remove them from the standard ruleset - IATI/IATI-Rulesets#17

Can be tested with the current ruleset framework:

Can not be tested with the current ruleset framework:

  • The budget element should be repeated for each year of the activity's duration
  • Each budget should cover a period no longer than 1 year

@Bjwebb Bjwebb modified the milestones: 2.01 Iteration 3, 2.01 Final Sep 9, 2014

@bill-anderson

This comment has been minimized.

Show comment
Hide comment
@bill-anderson
Contributor

bill-anderson commented Sep 11, 2014

@Bjwebb

This comment has been minimized.

Show comment
Hide comment
@Bjwebb

Bjwebb Sep 24, 2014

Contributor

Those rules above that can be implemented with the rulesets framework should now be implemented. IATI/IATI-Rulesets#17 (comment)

Rules that can't be tested with the rulesets framework will be added as documentation, and then tested with bespoke code: IATI/IATI-Extra-Documentation#250

Contributor

Bjwebb commented Sep 24, 2014

Those rules above that can be implemented with the rulesets framework should now be implemented. IATI/IATI-Rulesets#17 (comment)

Rules that can't be tested with the rulesets framework will be added as documentation, and then tested with bespoke code: IATI/IATI-Extra-Documentation#250

@Bjwebb

This comment has been minimized.

Show comment
Hide comment
@Bjwebb

Bjwebb Sep 25, 2014

Contributor

Since the work here is now covered by other issues, I am closing this issue.

Contributor

Bjwebb commented Sep 25, 2014

Since the work here is now covered by other issues, I am closing this issue.

@Bjwebb Bjwebb closed this Sep 25, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment