Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DesignableGradientView should conform to GradientDesignable #81

Closed
JakeLin opened this issue Feb 10, 2016 · 3 comments
Closed

DesignableGradientView should conform to GradientDesignable #81

JakeLin opened this issue Feb 10, 2016 · 3 comments

Comments

@JakeLin
Copy link
Member

JakeLin commented Feb 10, 2016

DesignableGradientView was a temporary view to wrap a layer. need to conform to GradientDesignable protocol.
@JakeLin JakeLin mentioned this issue Feb 10, 2016
Merged
@tbaranes
Copy link
Member

GradientDesignable should also implement startPoint process which is implemented in DesignableGradientView

@JakeLin
Copy link
Member Author

JakeLin commented Feb 10, 2016

Yes, move it in DesignableGradientView

@tbaranes tbaranes mentioned this issue Feb 10, 2016
Merged
@tbaranes
Copy link
Member

It still needs some improvements, but DesignableGradientView conforms to GradientDesignable.
Also, the startPoint is now working when conforming to GradientDesignable.

@tbaranes tbaranes mentioned this issue Feb 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JakeLin @tbaranes